Uploaded image for project: 'S2Graph'
  1. S2Graph
  2. S2GRAPH-58

Offset query option is not working with tall row schema

    XMLWordPrintableJSON

Details

    • Bug
    • Status: In Progress
    • Major
    • Resolution: Unresolved
    • None
    • None
    • None
    • None

    Description

      S2GRAPH-50 implemented new schema(tall row) for HBase Storage, but there were few missing parts our test cases missed out.

      One thing I found out is `offset` option on queryParam is not working. in wide row schema, we used `ColumnPaginationFilter` which accept offset and limit as parameter. in tall row schema, we need to change to use `PageFilter` and unlike `ColumnPaginationFilter`, `PageFilter` does not accept offset as parameter.

      I think we can either throw exception by checking compatibility on label's schema version and query, or we can implicitly fetch `offset + limit` key values and take only from offset index to limit.

      Or we can actually provide different option like providing cursors and let user to parse each cursors to paginate next chunk of edges. I am open to any suggestion, so feel free to give any opinion on this.

      Attachments

        Activity

          People

            steamshon Do Yung Yoon
            steamshon Do Yung Yoon
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:

              Time Tracking

                Estimated:
                Original Estimate - 336h
                336h
                Remaining:
                Remaining Estimate - 336h
                336h
                Logged:
                Time Spent - Not Specified
                Not Specified