Uploaded image for project: 'S2Graph'
  1. S2Graph
  2. S2GRAPH-237

Refactor unused variable on AnnoyIndexBuildSink class

    XMLWordPrintableJSON

Details

    • Bug
    • Status: To Do
    • Minor
    • Resolution: Unresolved
    • None
    • None
    • None
    • None

    Description

      val df = repartition(preprocess(inputDF), inputDF.sparkSession.sparkContext.defaultParallelism)
      
      if (inputDF.isStreaming) throw new IllegalStateException("AnnoyIndexBuildSink can not be run as streaming.")
      else {
            ALSModelProcess.buildAnnoyIndex(conf, inputDF)
      }
      

      In "write" method of AnnoyIndexBuildSink class, variable "df" is never used.
      So, repartition does not working .
      I think that second parameter of buildAnnoyIndex shoule be "df", not "inputDF".

      Attachments

        Activity

          People

            djfwan Hwansung Yu
            djfwan Hwansung Yu
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated: