[S2GRAPH-230] ResourceManager onEvict cause segmentation fault with AnnoyModelFetcher

• Type: Bug
• Status: Done
• Priority: Minor
• Resolution: Done
• Component/s: s2core
• Assignee: Do Yung Yoon
• Reporter: Do Yung Yoon
• Due: 06/Jul/18
• Created: 02/Jul/18 06:48
• Updated: 13/Jul/18 06:31
• Resolved: 13/Jul/18 06:31

Description

Current implementation causes the segmentation fault when the query on edges that bind to custom EdgeFetcher, more specifically AnnoyModelFetcher with cacheTTLInSecs as -1.

cacheTTLInSecs -1 means we initialize EdgeFetcher instance instead of using local cached instance.

SafeUpdateCache put newly instantiated EdgeFetcher instance into guava cache, then call `onEvict` method defined in ResourceManager, which immediately call close() on Annoy4s JNI library, which causes the segmentation fault.

One quick fix on this issue is scheduling EdgeFetcher's close method in a short period of time delay in the background.

Issue Links

• links to: GitHub Pull Request #179