[S2GRAPH-222] Support Not logical operator in WhereParser.

• Type: New Feature
• Status: Done
• Priority: Minor
• Resolution: Done
• Component/s: s2core
• Assignee: Do Yung Yoon
• Reporter: Do Yung Yoon
• Due: 29/Jun/18
• Created: 15/Jun/18 02:07
• Updated: 18/Jun/18 07:04
• Resolved: 18/Jun/18 07:04

Description

`And/Or` operator is implemented as a logical operator, but `Not` is not implemented in WhereParser.

This is illustrated by following examples.

Following query works only because we added hardcoded implementation on `not in` as predicates.

query {
  s2graph { 
    User(id: 1) {
      id
      Friends(limit: 10, filter: "friend_name not in ('steamshon')") {
        User { 
          id
        }
      }
    }
  }
}

I believe implementing `Not` as a logical operator is more general, so below is my suggestion.

query {
  s2graph { 
    User(id: 1) {
      id
      Friends(limit: 10, filter: "NOT (friend_name in ('steamshon'))") {
        User { 
          id
        }
      }
    }
  }
}

In this way, we don't need to implement not case for all predicates, such as `in`, `between`, `contains`, `eq`.

Issue Links

• links to: GitHub Pull Request #174