Uploaded image for project: 'S2Graph'
  1. S2Graph
  2. S2GRAPH-187

Make toQuery use toVertex to parse vertex from query JSON on RequestParser

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: In Progress
    • Trivial
    • Resolution: Unresolved
    • None
    • None
    • None
    • None

    Description

      There is code duplication on `toQuery` and `toVertex` at `RequestParser`.

      Both of two methods need to read JSON value and extract vertex.
      The only difference between two is `toQuery` only need vertexId, not props, timestamp, operation, but `toVertex` need others.

      Different implementation increase probability for bugs like S2GRAPH-186, so I suggest refactoring theses.

      Attachments

        Issue Links

          Activity

            People

              steamshon Do Yung Yoon
              steamshon Do Yung Yoon
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:

                Time Tracking

                  Estimated:
                  Original Estimate - 48h
                  48h
                  Remaining:
                  Remaining Estimate - 48h
                  48h
                  Logged:
                  Time Spent - Not Specified
                  Not Specified