[ROL-2101] Thread unsafe use of HashMap for cached mappings exist

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 5.1.2
• Fix Version/s: 5.2.0
• Component/s: Data Model & JPA Backend
• Assignee: Roller Unassigned
• Reporter: Kohei Nozaki
• Created: 11/Jan/16 02:30
• Updated: 01/Jul/17 21:38
• Resolved: 23/Oct/16 07:47

Description

There are two singleton classes that have a instance field type of HashMap for cache.

In JPAUserManagerImpl:

// cached mapping of userNames -> userIds
private Map<String, String> userNameToIdMap = new HashMap<String, String>();

In JPAWeblogEntryManagerImpl:

// cached mapping of entryAnchors -> entryIds
private Map<String, String> entryAnchorToIdMap = new HashMap<String, String>();

HashMap s should not be used as the above because it's not thread safe.

Issue Links

• links to: GitHub Pull Request #5