Uploaded image for project: 'Apache Roller'
  1. Apache Roller
  2. ROL-2059

Comment preview is invisible in Gaurav theme

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 5.1.1
    • Fix Version/s: 5.1.2
    • Component/s: Themes and Macros
    • Labels:
      None

      Description

      "No one has commented yet." is shown while I fill comment form and hit Preview button. I think the cause is that #if($model.commentForm.preview) is placed inside #if($entry.commentCount > 0 ) in entry.vm. a preview comment won't be counted as $entry.commentCount so it won't work as expected.

      1. ROL-2059.patch
        2 kB
        Kohei Nozaki

        Activity

        Hide
        xkylex Kohei Nozaki added a comment -

        Fix placing of if-else clause and delete unnecessary #showWeblogEntryComments($entry) invocation.

        Show
        xkylex Kohei Nozaki added a comment - Fix placing of if-else clause and delete unnecessary #showWeblogEntryComments($entry) invocation.
        Hide
        djohnson David Johnson added a comment -

        Patch looks good. Thanks Kohei!

        $ svn commit -m "Comment preview fix in Gaurav theme from Kohei Nozaki (ROL-2059)" .
        Sending app/src/main/webapp/themes/gaurav/entry.vm
        Transmitting file data .
        Committed revision 1658181.

        Show
        djohnson David Johnson added a comment - Patch looks good. Thanks Kohei! $ svn commit -m "Comment preview fix in Gaurav theme from Kohei Nozaki ( ROL-2059 )" . Sending app/src/main/webapp/themes/gaurav/entry.vm Transmitting file data . Committed revision 1658181.
        Hide
        djohnson David Johnson added a comment -

        5.1.2 released

        Show
        djohnson David Johnson added a comment - 5.1.2 released

          People

          • Assignee:
            djohnson David Johnson
            Reporter:
            xkylex Kohei Nozaki
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development