[ROL-1776] feed servlet may not call correct template

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 5.0
• Fix Version/s: 4.0.1, 5.0
• Component/s: Newsfeeds (RSS & Atom)
• Environment: Fedora 8
• Assignee: David Johnson
• Reporter: Greg Huber
• Created: 14/Jan/09 08:57
• Updated: 08/Jan/14 04:13
• Resolved: 19/Jan/09 21:05

Description

In the feed servlet the "templates/feeds/weblog-search-atom.vm" may not be called correclty.

for the code:
// determine what template to render with
boolean siteWide = WebloggerRuntimeConfig.isSiteWideWeblog(weblog.getHandle());
if ("entries".equals(feedRequest.getType()) && feedRequest.getTerm() != null)

{ pageId = "templates/feeds/site-search-atom.vm"; }

else if (siteWide && "entries".equals(feedRequest.getType()) && feedRequest.getTerm() != null)

{ pageId = "templates/feeds/weblog-search-atom.vm"; } else if (siteWide) { pageId = "templates/feeds/site-"+feedRequest.getType()+"-"+feedRequest.getFormat()+".vm"; } else { pageId = "templates/feeds/weblog-"+feedRequest.getType()+"-"+feedRequest.getFormat()+".vm"; }

the siteWide refers to "templates/feeds/weblog-search-atom.vm" where it should refer to "templates/feeds/site-search-atom.vm".

ie code may need to be:

// determine what template to render with
boolean siteWide = WebloggerRuntimeConfig.isSiteWideWeblog(weblog.getHandle());
if (siteWide && "entries".equals(feedRequest.getType()) && feedRequest.getTerm() != null) { pageId = "templates/feeds/site-search-atom.vm"; } else if ("entries".equals(feedRequest.getType()) && feedRequest.getTerm() != null) { pageId = "templates/feeds/weblog-search-atom.vm"; }

else if (siteWide)

{ pageId = "templates/feeds/site-"+feedRequest.getType()+"-"+feedRequest.getFormat()+".vm"; }

else

{ pageId = "templates/feeds/weblog-"+feedRequest.getType()+"-"+feedRequest.getFormat()+".vm"; }