Uploaded image for project: 'Apache Roller'
  1. Apache Roller
  2. ROL-1750

PlanetURLStrategy needs to be moved out of ui package

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • None
    • 5.0
    • None
    • less than a day to move this class to the right package and change the references (1 class)

    Description

      The location of PlanetURLStrategy.java is preventing a clear separation between web tier and business tier.

      This class is currently packaged under org.apache.roller.weblogger.planet.ui. Like all other Strategy classes, this belongs to business layer and so should probably go under org.apache.roller.weblogger.planet.business

      I discovered this issue when I tried to create separate projects for web and business layers in my Eclipse IDE. I followed the inclusion and exclusion patterns defined in the ant script, removed roller-business.jar and roller-web.jar from classpath to avoid duplication and made my web project dependent on business project. At this point, I am getting compilation error in org/apache/roller/weblogger/planet/business/jpa/RollerPlanetModule.java (business project) as it is referring to PlanetURLStrategy.java, which is in web project because of the way inclusion/exclusion patterns are defined.

      This problem can be easily resolved by moving PlanetURLStrategy.java from org.apache.roller.weblogger.planet.ui to org.apache.roller.weblogger.planet.business

      Attachments

        1. move_PlanetURLStrategy.patch
          6 kB
          Ganesh Mathrerootham

        Activity

          People

            djohnson David Johnson
            ganeshmb Ganesh Mathrerootham
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: