[ROL-1167] Authentication failure in Atom API leads to NullPointerException in RollerAtomHandler

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.3
• Component/s: Web Services
• Environment: All
• Level of effort: Trivial, see patch above
• Assignee: Unassigned
• Reporter: Padraig O hIceadha
• Created: 16/Jun/06 15:25
• Updated: 06/Oct/14 19:57
• Resolved: 06/Oct/14 19:57

Description

If an incorrect username or password is used ehen e.g. posting a new entry via the Atom API instead of getting a 401 error (Unauthorized) you get a 500 server error because of a NullPOinterException in RollerAtomHandler.

RollerAtomHandler#getAuthenticatedUsername was not checking if this.user was null.

The patch for my proposed fix is below :
Index: RollerAtomHandler.java
===================================================================
— RollerAtomHandler.java (revision 414838)
+++ RollerAtomHandler.java (working copy)
@@ -121,6 +121,9 @@

• Return weblogHandle of authenticated user or null if there is none.
  */
  public String getAuthenticatedUsername()
  Unknown macro: {+ if (this.user == null) { + return null; + } return this.user.getUserName(); }