Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 4.0.0-incubating
    • Fix Version/s: 4.2.0
    • Component/s: rocketmq-client
    • Labels:
      None

      Description

      Some variable is named with tmp which is very difficult to read and understand its usage.

      For exampe:

      1. in sendDefaultImpl, when select message queue, the variable is named with

      MessageQueue tmpmq = this.selectOneMessageQueue(topicPublishInfo, lastBrokerName);

      2. In process queue, a field is named `msgTreeMapTemp`, which takes me minutes to understand why it is desgined for, which should be rename to some name like consumeingOrderlyMsgTreeMap

        Attachments

          Activity

            People

            • Assignee:
              Jaskey Jaskey Lam
              Reporter:
              Jaskey Jaskey Lam
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: