Uploaded image for project: 'Apache RocketMQ'
  1. Apache RocketMQ
  2. ROCKETMQ-96

Rename tmp variable

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 4.0.0-incubating
    • 4.2.0
    • rocketmq-client
    • None

    Description

      Some variable is named with tmp which is very difficult to read and understand its usage.

      For exampe:

      1. in sendDefaultImpl, when select message queue, the variable is named with

      MessageQueue tmpmq = this.selectOneMessageQueue(topicPublishInfo, lastBrokerName);

      2. In process queue, a field is named `msgTreeMapTemp`, which takes me minutes to understand why it is desgined for, which should be rename to some name like consumeingOrderlyMsgTreeMap

      Attachments

        Activity

          People

            Jaskey Jaskey Lam
            Jaskey Jaskey Lam
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: