Uploaded image for project: 'Apache RocketMQ'
  1. Apache RocketMQ
  2. ROCKETMQ-8

Standardize build script using maven wrapper

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0.0-incubating
    • Component/s: None
    • Labels:
    • Flags:
      Patch

      Issue Links

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user lollipopjin opened a pull request:

        https://github.com/apache/incubator-rocketmq/pull/5

        ROCKETMQ-8Standardize build script using maven wrapper.

        Step1:
        Remove original scripts.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/lollipopjin/incubator-rocketmq master

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/incubator-rocketmq/pull/5.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #5


        commit a61a82d05cb4e66eb91e955ad65a1f950bf6e3b4
        Author: lollipop <lollipop@apache.org>
        Date: 2016-12-23T02:42:22Z

        Improvement: Standardize build script using maven wrapper.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user lollipopjin opened a pull request: https://github.com/apache/incubator-rocketmq/pull/5 ROCKETMQ-8 Standardize build script using maven wrapper. Step1: Remove original scripts. You can merge this pull request into a Git repository by running: $ git pull https://github.com/lollipopjin/incubator-rocketmq master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-rocketmq/pull/5.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5 commit a61a82d05cb4e66eb91e955ad65a1f950bf6e3b4 Author: lollipop <lollipop@apache.org> Date: 2016-12-23T02:42:22Z Improvement: Standardize build script using maven wrapper.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user vongosling commented on the issue:

        https://github.com/apache/incubator-rocketmq/pull/5

        Sorry, we don't merge this PR.
        IMO, there is step 2 you must finish

        Show
        githubbot ASF GitHub Bot added a comment - Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq/pull/5 Sorry, we don't merge this PR. IMO, there is step 2 you must finish
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user lollipopjin commented on the issue:

        https://github.com/apache/incubator-rocketmq/pull/5

        @vongosling
        I have finished all steps.

        Show
        githubbot ASF GitHub Bot added a comment - Github user lollipopjin commented on the issue: https://github.com/apache/incubator-rocketmq/pull/5 @vongosling I have finished all steps.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user vongosling commented on the issue:

        https://github.com/apache/incubator-rocketmq/pull/5

        Thanks for your PR.
        I have checked it. It's seems ok for me. please @stevenschew @zhouxinyu review it.

        Show
        githubbot ASF GitHub Bot added a comment - Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq/pull/5 Thanks for your PR. I have checked it. It's seems ok for me. please @stevenschew @zhouxinyu review it.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user zhouxinyu commented on the issue:

        https://github.com/apache/incubator-rocketmq/pull/5

        It seems ok.

        Show
        githubbot ASF GitHub Bot added a comment - Github user zhouxinyu commented on the issue: https://github.com/apache/incubator-rocketmq/pull/5 It seems ok.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user stevenschew commented on the issue:

        https://github.com/apache/incubator-rocketmq/pull/5

        review Ok!

        Show
        githubbot ASF GitHub Bot added a comment - Github user stevenschew commented on the issue: https://github.com/apache/incubator-rocketmq/pull/5 review Ok!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/incubator-rocketmq/pull/5

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/incubator-rocketmq/pull/5

          People

          • Assignee:
            lollipop Jixiang Jin
            Reporter:
            lollipop Jixiang Jin
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development