Details

      Description

      NettyRemotingClient contains two methods doing the same thing as overridden getRPCHook and getNameServerAddressList.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user lollipopjin commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/48

          Done with the review work

          Show
          githubbot ASF GitHub Bot added a comment - Github user lollipopjin commented on the issue: https://github.com/apache/incubator-rocketmq/pull/48 Done with the review work
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/incubator-rocketmq/pull/48

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/incubator-rocketmq/pull/48
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 169450e1f946951d18c17e3f86b988b46c4c8672 in incubator-rocketmq's branch refs/heads/master from shroman
          [ https://git-wip-us.apache.org/repos/asf?p=incubator-rocketmq.git;h=169450e ]

          ROCKETMQ-70 Duplicate methods in NettyRemotingClient, closes apache/incubator-rocketmq#48

          Show
          jira-bot ASF subversion and git services added a comment - Commit 169450e1f946951d18c17e3f86b988b46c4c8672 in incubator-rocketmq's branch refs/heads/master from shroman [ https://git-wip-us.apache.org/repos/asf?p=incubator-rocketmq.git;h=169450e ] ROCKETMQ-70 Duplicate methods in NettyRemotingClient, closes apache/incubator-rocketmq#48
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user vongosling commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/48

          alright

          Show
          githubbot ASF GitHub Bot added a comment - Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq/pull/48 alright
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user coveralls commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/48

          [![Coverage Status](https://coveralls.io/builds/9785769/badge)](https://coveralls.io/builds/9785769)

          Coverage decreased (-0.06%) to 26.245% when pulling *e14c18c04f8f2aafdf3ce9acc9fbbe4bdca7a8d1 on shroman:ROCKETMQ-70* into *881aef5d3195b918c87043ea75a19a3fb805b2e0 on apache:master*.

          Show
          githubbot ASF GitHub Bot added a comment - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/48 [! [Coverage Status] ( https://coveralls.io/builds/9785769/badge)](https://coveralls.io/builds/9785769 ) Coverage decreased (-0.06%) to 26.245% when pulling * e14c18c04f8f2aafdf3ce9acc9fbbe4bdca7a8d1 on shroman: ROCKETMQ-70 * into * 881aef5d3195b918c87043ea75a19a3fb805b2e0 on apache:master *.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user coveralls commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/48

          [![Coverage Status](https://coveralls.io/builds/9785769/badge)](https://coveralls.io/builds/9785769)

          Coverage decreased (-0.06%) to 26.245% when pulling *e14c18c04f8f2aafdf3ce9acc9fbbe4bdca7a8d1 on shroman:ROCKETMQ-70* into *881aef5d3195b918c87043ea75a19a3fb805b2e0 on apache:master*.

          Show
          githubbot ASF GitHub Bot added a comment - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/48 [! [Coverage Status] ( https://coveralls.io/builds/9785769/badge)](https://coveralls.io/builds/9785769 ) Coverage decreased (-0.06%) to 26.245% when pulling * e14c18c04f8f2aafdf3ce9acc9fbbe4bdca7a8d1 on shroman: ROCKETMQ-70 * into * 881aef5d3195b918c87043ea75a19a3fb805b2e0 on apache:master *.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user coveralls commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/48

          [![Coverage Status](https://coveralls.io/builds/9785769/badge)](https://coveralls.io/builds/9785769)

          Coverage decreased (-0.06%) to 26.245% when pulling *e14c18c04f8f2aafdf3ce9acc9fbbe4bdca7a8d1 on shroman:ROCKETMQ-70* into *881aef5d3195b918c87043ea75a19a3fb805b2e0 on apache:master*.

          Show
          githubbot ASF GitHub Bot added a comment - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/48 [! [Coverage Status] ( https://coveralls.io/builds/9785769/badge)](https://coveralls.io/builds/9785769 ) Coverage decreased (-0.06%) to 26.245% when pulling * e14c18c04f8f2aafdf3ce9acc9fbbe4bdca7a8d1 on shroman: ROCKETMQ-70 * into * 881aef5d3195b918c87043ea75a19a3fb805b2e0 on apache:master *.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user shroman commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/48

          Simply removal of duplicate methods. Ready for review.

          Show
          githubbot ASF GitHub Bot added a comment - Github user shroman commented on the issue: https://github.com/apache/incubator-rocketmq/pull/48 Simply removal of duplicate methods. Ready for review.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user shroman opened a pull request:

          https://github.com/apache/incubator-rocketmq/pull/48

          ROCKETMQ-70 Duplicate methods in NettyRemotingClient

          JIRA issue: https://issues.apache.org/jira/browse/ROCKETMQ-70

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/shroman/incubator-rocketmq ROCKETMQ-70

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/incubator-rocketmq/pull/48.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #48


          commit e14c18c04f8f2aafdf3ce9acc9fbbe4bdca7a8d1
          Author: shroman <rshtykh@yahoo.com>
          Date: 2017-01-22T09:07:14Z

          ROCKETMQ-70 Duplicate methods in NettyRemotingClient

          JIRA issue: https://issues.apache.org/jira/browse/ROCKETMQ-70


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user shroman opened a pull request: https://github.com/apache/incubator-rocketmq/pull/48 ROCKETMQ-70 Duplicate methods in NettyRemotingClient JIRA issue: https://issues.apache.org/jira/browse/ROCKETMQ-70 You can merge this pull request into a Git repository by running: $ git pull https://github.com/shroman/incubator-rocketmq ROCKETMQ-70 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-rocketmq/pull/48.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #48 commit e14c18c04f8f2aafdf3ce9acc9fbbe4bdca7a8d1 Author: shroman <rshtykh@yahoo.com> Date: 2017-01-22T09:07:14Z ROCKETMQ-70 Duplicate methods in NettyRemotingClient JIRA issue: https://issues.apache.org/jira/browse/ROCKETMQ-70

            People

            • Assignee:
              roman_s Roman Shtykh
              Reporter:
              roman_s Roman Shtykh
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development