Uploaded image for project: 'Apache RocketMQ'
  1. Apache RocketMQ
  2. ROCKETMQ-64

Remove duplication code line in BrokerOuterAPI.registerBroker method

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0.0-incubating
    • Component/s: None
    • Labels:
      None

      Description

      Duplicated code line 'result.setHaServerAddr(responseHeader.getHaServerAddr());' in BrokerOuterAPI.registerBroker method.

        Issue Links

          Activity

          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 581039bef2b6a628ec1611f24880b87d8a8d6fd7 in incubator-rocketmq's branch refs/heads/ROCKETMQ-57 from yukon
          [ https://git-wip-us.apache.org/repos/asf?p=incubator-rocketmq.git;h=581039b ]

          ROCKETMQ-64 Remove duplication code line in BrokerOuterAPI.registerBroker method, thanks @naughtybear, closes apache/incubator-rocketmq#44

          Show
          jira-bot ASF subversion and git services added a comment - Commit 581039bef2b6a628ec1611f24880b87d8a8d6fd7 in incubator-rocketmq's branch refs/heads/ ROCKETMQ-57 from yukon [ https://git-wip-us.apache.org/repos/asf?p=incubator-rocketmq.git;h=581039b ] ROCKETMQ-64 Remove duplication code line in BrokerOuterAPI.registerBroker method, thanks @naughtybear, closes apache/incubator-rocketmq#44
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/incubator-rocketmq/pull/44

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/incubator-rocketmq/pull/44
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 581039bef2b6a628ec1611f24880b87d8a8d6fd7 in incubator-rocketmq's branch refs/heads/master from yukon
          [ https://git-wip-us.apache.org/repos/asf?p=incubator-rocketmq.git;h=581039b ]

          ROCKETMQ-64 Remove duplication code line in BrokerOuterAPI.registerBroker method, thanks @naughtybear, closes apache/incubator-rocketmq#44

          Show
          jira-bot ASF subversion and git services added a comment - Commit 581039bef2b6a628ec1611f24880b87d8a8d6fd7 in incubator-rocketmq's branch refs/heads/master from yukon [ https://git-wip-us.apache.org/repos/asf?p=incubator-rocketmq.git;h=581039b ] ROCKETMQ-64 Remove duplication code line in BrokerOuterAPI.registerBroker method, thanks @naughtybear, closes apache/incubator-rocketmq#44
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user vongosling commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/44

          Thanks @naughtybear

          Show
          githubbot ASF GitHub Bot added a comment - Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq/pull/44 Thanks @naughtybear
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user naughtybear commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/44

          link to jira issue [64](https://issues.apache.org/jira/browse/ROCKETMQ-64)

          Show
          githubbot ASF GitHub Bot added a comment - Github user naughtybear commented on the issue: https://github.com/apache/incubator-rocketmq/pull/44 link to jira issue [64] ( https://issues.apache.org/jira/browse/ROCKETMQ-64 )
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user naughtybear opened a pull request:

          https://github.com/apache/incubator-rocketmq/pull/44

          ROCKETMQ-64 Remove duplication code line in BrokerOuterAPI.registerBroker method

          Remove duplicated 'result.setHaServerAddr(responseHeader.getHaServerAddr());' in BrokerOuterAPI.registerBroker method

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/naughtybear/incubator-rocketmq master

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/incubator-rocketmq/pull/44.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #44


          commit 17527ddd2f59df943d2251814c51c615a7b7b531
          Author: Eric Han <erichan_bj@outlook.com>
          Date: 2017-01-17T02:43:09Z

          Remove duplication code line

          Remove duplicated 'result.setHaServerAddr(responseHeader.getHaServerAddr());' in BrokerOuterAPI.registerBroker method


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user naughtybear opened a pull request: https://github.com/apache/incubator-rocketmq/pull/44 ROCKETMQ-64 Remove duplication code line in BrokerOuterAPI.registerBroker method Remove duplicated 'result.setHaServerAddr(responseHeader.getHaServerAddr());' in BrokerOuterAPI.registerBroker method You can merge this pull request into a Git repository by running: $ git pull https://github.com/naughtybear/incubator-rocketmq master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-rocketmq/pull/44.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #44 commit 17527ddd2f59df943d2251814c51c615a7b7b531 Author: Eric Han <erichan_bj@outlook.com> Date: 2017-01-17T02:43:09Z Remove duplication code line Remove duplicated 'result.setHaServerAddr(responseHeader.getHaServerAddr());' in BrokerOuterAPI.registerBroker method

            People

            • Assignee:
              vongosling vongosling
              Reporter:
              erichan hanzhaozhan
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development