Uploaded image for project: 'Apache RocketMQ'
  1. Apache RocketMQ
  2. ROCKETMQ-5

Avoid creating directories in UtilAll#getDiskPartitionSpaceUsedPercent()

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0.0-incubating
    • Component/s: None
    • Labels:
      None

      Description

      Since UtilAll#getDiskPartitionSpaceUsedPercent() is a diagnostic method, rather than creating a directory if it is not found, produce an error log that the directory is supposed to exist and return -1.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user shroman opened a pull request:

          https://github.com/apache/incubator-rocketmq/pull/6

          ROCKETMQ-5 Avoid creating directories in UtilAll#getDiskPartitionSp…

          …aceUsedPercent()

          Jira issue: https://issues.apache.org/jira/browse/ROCKETMQ-5

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/shroman/incubator-rocketmq ROCKETMQ-5

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/incubator-rocketmq/pull/6.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #6


          commit fb113a859b82cc22a83cdf97bd811bb2f2a5aca0
          Author: shroman <rshtykh@yahoo.com>
          Date: 2016-12-23T06:38:50Z

          ROCKETMQ-5 Avoid creating directories in UtilAll#getDiskPartitionSpaceUsedPercent()

          Jira issue: https://issues.apache.org/jira/browse/ROCKETMQ-5


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user shroman opened a pull request: https://github.com/apache/incubator-rocketmq/pull/6 ROCKETMQ-5 Avoid creating directories in UtilAll#getDiskPartitionSp… …aceUsedPercent() Jira issue: https://issues.apache.org/jira/browse/ROCKETMQ-5 You can merge this pull request into a Git repository by running: $ git pull https://github.com/shroman/incubator-rocketmq ROCKETMQ-5 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-rocketmq/pull/6.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #6 commit fb113a859b82cc22a83cdf97bd811bb2f2a5aca0 Author: shroman <rshtykh@yahoo.com> Date: 2016-12-23T06:38:50Z ROCKETMQ-5 Avoid creating directories in UtilAll#getDiskPartitionSpaceUsedPercent() Jira issue: https://issues.apache.org/jira/browse/ROCKETMQ-5
          Hide
          roman_s Roman Shtykh added a comment - - edited

          vongosling Ready for a review.

          Show
          roman_s Roman Shtykh added a comment - - edited vongosling Ready for a review.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user lollipopjin commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/6

          @shroman Could you please squash your commits and fix conflicts.

          Show
          githubbot ASF GitHub Bot added a comment - Github user lollipopjin commented on the issue: https://github.com/apache/incubator-rocketmq/pull/6 @shroman Could you please squash your commits and fix conflicts.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user shroman closed the pull request at:

          https://github.com/apache/incubator-rocketmq/pull/6

          Show
          githubbot ASF GitHub Bot added a comment - Github user shroman closed the pull request at: https://github.com/apache/incubator-rocketmq/pull/6
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user shroman opened a pull request:

          https://github.com/apache/incubator-rocketmq/pull/23

          ROCKETMQ-5 Avoid creating directories in UtilAll#getDiskPartitionSp…

          …aceUsedPercent()

          JIRA issue: https://issues.apache.org/jira/browse/ROCKETMQ-5

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/shroman/incubator-rocketmq ROCKETMQ-5

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/incubator-rocketmq/pull/23.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #23


          commit 8d78c7313ccbf7a38fc0d61e44a32cd13dc5f462
          Author: shroman <rshtykh@yahoo.com>
          Date: 2016-12-29T08:37:15Z

          ROCKETMQ-5 Avoid creating directories in UtilAll#getDiskPartitionSpaceUsedPercent()

          JIRA issue: https://issues.apache.org/jira/browse/ROCKETMQ-5


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user shroman opened a pull request: https://github.com/apache/incubator-rocketmq/pull/23 ROCKETMQ-5 Avoid creating directories in UtilAll#getDiskPartitionSp… …aceUsedPercent() JIRA issue: https://issues.apache.org/jira/browse/ROCKETMQ-5 You can merge this pull request into a Git repository by running: $ git pull https://github.com/shroman/incubator-rocketmq ROCKETMQ-5 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-rocketmq/pull/23.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #23 commit 8d78c7313ccbf7a38fc0d61e44a32cd13dc5f462 Author: shroman <rshtykh@yahoo.com> Date: 2016-12-29T08:37:15Z ROCKETMQ-5 Avoid creating directories in UtilAll#getDiskPartitionSpaceUsedPercent() JIRA issue: https://issues.apache.org/jira/browse/ROCKETMQ-5
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user shroman commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/23

          @lollipopjin I recreated the pull request. Ready for the review.

          Show
          githubbot ASF GitHub Bot added a comment - Github user shroman commented on the issue: https://github.com/apache/incubator-rocketmq/pull/23 @lollipopjin I recreated the pull request. Ready for the review.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user lollipopjin commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/23

          Great. @vongosling @zhouxinyu PLZ review the code.

          Show
          githubbot ASF GitHub Bot added a comment - Github user lollipopjin commented on the issue: https://github.com/apache/incubator-rocketmq/pull/23 Great. @vongosling @zhouxinyu PLZ review the code.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user vongosling commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/23

          alright for me

          Show
          githubbot ASF GitHub Bot added a comment - Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq/pull/23 alright for me
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zhouxinyu commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/23

          Great. Thanks @shroman

          Show
          githubbot ASF GitHub Bot added a comment - Github user zhouxinyu commented on the issue: https://github.com/apache/incubator-rocketmq/pull/23 Great. Thanks @shroman
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user shroman commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/23

          Thank you, guys. I will close the issue after it is merged then.

          Show
          githubbot ASF GitHub Bot added a comment - Github user shroman commented on the issue: https://github.com/apache/incubator-rocketmq/pull/23 Thank you, guys. I will close the issue after it is merged then.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 9cb0a0cd46cf91b324b7c6c66d7479d21073d6f6 in incubator-rocketmq's branch refs/heads/master from shroman
          [ https://git-wip-us.apache.org/repos/asf?p=incubator-rocketmq.git;h=9cb0a0c ]

          ROCKETMQ-5 Avoid creating directories in UtilAll#getDiskPartitionSpaceUsedPercent(), closes apache/incubator-rocketmq#23

          Show
          jira-bot ASF subversion and git services added a comment - Commit 9cb0a0cd46cf91b324b7c6c66d7479d21073d6f6 in incubator-rocketmq's branch refs/heads/master from shroman [ https://git-wip-us.apache.org/repos/asf?p=incubator-rocketmq.git;h=9cb0a0c ] ROCKETMQ-5 Avoid creating directories in UtilAll#getDiskPartitionSpaceUsedPercent(), closes apache/incubator-rocketmq#23
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/incubator-rocketmq/pull/23

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/incubator-rocketmq/pull/23
          Hide
          roman_s Roman Shtykh added a comment -

          Merged.

          Show
          roman_s Roman Shtykh added a comment - Merged.

            People

            • Assignee:
              roman_s Roman Shtykh
              Reporter:
              roman_s Roman Shtykh
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development