[ROCKETMQ-39] Duplicated codes in both filtersrv and namesrv modules

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 4.1.0-incubating
• Component/s: rocketmq-namesrv
• Assignee: Xiaorui Wang
• Reporter: Sheng Wu
• Created: 11/Jan/17 02:33
• Updated: 06/Jun/17 03:38
• Resolved: 11/Jan/17 08:07

Description

In FiltersrvStartup.class and NamesrvStartup.class, exist the exact same code about add jvm shutdown hook, and execute somthing on shutting down.

Runtime.getRuntime().addShutdownHook(new Thread(new Runnable() {
private volatile boolean hasShutdown = false;
private AtomicInteger shutdownTimes = new AtomicInteger(0);

@Override
public void run() {
synchronized (this) {
log.info("shutdown hook was invoked, " + this.shutdownTimes.incrementAndGet());
if (!this.hasShutdown)

{ this.hasShutdown = true; long begineTime = System.currentTimeMillis(); controller.shutdown(); long consumingTimeTotal = System.currentTimeMillis() - begineTime; log.info("shutdown hook over, consuming time total(ms): " + consumingTimeTotal); }

}
}
}, "ShutdownHook"));

Issue Links

• links to: GitHub Pull Request #34