Uploaded image for project: 'Apache RocketMQ'
  1. Apache RocketMQ
  2. ROCKETMQ-39

Duplicated codes in both filtersrv and namesrv modules

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.1.0-incubating
    • Component/s: rocketmq-namesrv
    • Labels:
      None

      Description

      In FiltersrvStartup.class and NamesrvStartup.class, exist the exact same code about add jvm shutdown hook, and execute somthing on shutting down.

      Runtime.getRuntime().addShutdownHook(new Thread(new Runnable() {
      private volatile boolean hasShutdown = false;
      private AtomicInteger shutdownTimes = new AtomicInteger(0);

      @Override
      public void run() {
      synchronized (this) {
      log.info("shutdown hook was invoked, " + this.shutdownTimes.incrementAndGet());
      if (!this.hasShutdown)

      { this.hasShutdown = true; long begineTime = System.currentTimeMillis(); controller.shutdown(); long consumingTimeTotal = System.currentTimeMillis() - begineTime; log.info("shutdown hook over, consuming time total(ms): " + consumingTimeTotal); }

      }
      }
      }, "ShutdownHook"));

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user wu-sheng opened a pull request:

          https://github.com/apache/incubator-rocketmq/pull/34

          fix/ROCKETMQ-39: avoid duplicated codes.

          ref issue: https://issues.apache.org/jira/browse/ROCKETMQ-39

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/wu-sheng/incubator-rocketmq fix/ROCKETMQ-39

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/incubator-rocketmq/pull/34.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #34


          commit 02a2d0eab3c5ffccd74a2226ed0d5b59509c3d21
          Author: wusheng <wu.sheng@foxmail.com>
          Date: 2017-01-11T02:34:18Z

          fix/ROCKETMQ-39: avoid duplicated codes.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user wu-sheng opened a pull request: https://github.com/apache/incubator-rocketmq/pull/34 fix/ ROCKETMQ-39 : avoid duplicated codes. ref issue: https://issues.apache.org/jira/browse/ROCKETMQ-39 You can merge this pull request into a Git repository by running: $ git pull https://github.com/wu-sheng/incubator-rocketmq fix/ ROCKETMQ-39 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-rocketmq/pull/34.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #34 commit 02a2d0eab3c5ffccd74a2226ed0d5b59509c3d21 Author: wusheng <wu.sheng@foxmail.com> Date: 2017-01-11T02:34:18Z fix/ ROCKETMQ-39 : avoid duplicated codes.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user lizhanhui commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/34

          The extracted shutdown hook misses required license header and causes check-style failure. Please fix it and double check if there are more similar code style issues.

          You may refer [here](http://rocketmq.incubator.apache.org/docs/code-guidelines/) in terms of code style.

          Show
          githubbot ASF GitHub Bot added a comment - Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq/pull/34 The extracted shutdown hook misses required license header and causes check-style failure. Please fix it and double check if there are more similar code style issues. You may refer [here] ( http://rocketmq.incubator.apache.org/docs/code-guidelines/ ) in terms of code style.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user vongosling commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/34

          @wu-sheng Could you modify your PR , following our codestyle and PR guide[1]

          [1]http://rocketmq.incubator.apache.org/docs/code-guidelines/

          Show
          githubbot ASF GitHub Bot added a comment - Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq/pull/34 @wu-sheng Could you modify your PR , following our codestyle and PR guide [1] [1] http://rocketmq.incubator.apache.org/docs/code-guidelines/
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user wu-sheng commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/34

          @vongosling , fixed and done. Hoping `style-check` works well next time. 😭

          Show
          githubbot ASF GitHub Bot added a comment - Github user wu-sheng commented on the issue: https://github.com/apache/incubator-rocketmq/pull/34 @vongosling , fixed and done. Hoping `style-check` works well next time. 😭
          Hide
          wu-sheng Wu Sheng added a comment -

          Pull request on github.

          Show
          wu-sheng Wu Sheng added a comment - Pull request on github.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user WillemJiang commented on a diff in the pull request:

          https://github.com/apache/incubator-rocketmq/pull/34#discussion_r95544500

          — Diff: filtersrv/src/main/java/org/apache/rocketmq/filtersrv/FiltersrvStartup.java —
          @@ -135,27 +137,17 @@ public static FiltersrvController createController(String[] args)

          { System.exit(-3); }
          • Runtime.getRuntime().addShutdownHook(new Thread(new Runnable() {
          • private volatile boolean hasShutdown = false;
          • private AtomicInteger shutdownTimes = new AtomicInteger(0);
            -
            + Runtime.getRuntime().addShutdownHook(new ShutdownHookThread(log, new Callable() {
            @Override
          • public void run() {
          • synchronized (this) {
          • log.info("shutdown hook was invoked, " + this.shutdownTimes.incrementAndGet());
          • if (!this.hasShutdown) { - this.hasShutdown = true; - long begineTime = System.currentTimeMillis(); - controller.shutdown(); - long consumingTimeTotal = System.currentTimeMillis() - begineTime; - log.info("shutdown hook over, consuming time total(ms): " + consumingTimeTotal); - }
          • }
            + public Object call() throws Exception {
              • End diff –

          If you don't want to return any thing here , you could define the method just like this.
          public Void call() throws Exception {
          }

          Show
          githubbot ASF GitHub Bot added a comment - Github user WillemJiang commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/34#discussion_r95544500 — Diff: filtersrv/src/main/java/org/apache/rocketmq/filtersrv/FiltersrvStartup.java — @@ -135,27 +137,17 @@ public static FiltersrvController createController(String[] args) { System.exit(-3); } Runtime.getRuntime().addShutdownHook(new Thread(new Runnable() { private volatile boolean hasShutdown = false; private AtomicInteger shutdownTimes = new AtomicInteger(0); - + Runtime.getRuntime().addShutdownHook(new ShutdownHookThread(log, new Callable() { @Override public void run() { synchronized (this) { log.info("shutdown hook was invoked, " + this.shutdownTimes.incrementAndGet()); if (!this.hasShutdown) { - this.hasShutdown = true; - long begineTime = System.currentTimeMillis(); - controller.shutdown(); - long consumingTimeTotal = System.currentTimeMillis() - begineTime; - log.info("shutdown hook over, consuming time total(ms): " + consumingTimeTotal); - } } + public Object call() throws Exception { End diff – If you don't want to return any thing here , you could define the method just like this. public Void call() throws Exception { }
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user wu-sheng commented on a diff in the pull request:

          https://github.com/apache/incubator-rocketmq/pull/34#discussion_r95546560

          — Diff: filtersrv/src/main/java/org/apache/rocketmq/filtersrv/FiltersrvStartup.java —
          @@ -135,27 +137,17 @@ public static FiltersrvController createController(String[] args)

          { System.exit(-3); }
          • Runtime.getRuntime().addShutdownHook(new Thread(new Runnable() {
          • private volatile boolean hasShutdown = false;
          • private AtomicInteger shutdownTimes = new AtomicInteger(0);
            -
            + Runtime.getRuntime().addShutdownHook(new ShutdownHookThread(log, new Callable() {
            @Override
          • public void run() {
          • synchronized (this) {
          • log.info("shutdown hook was invoked, " + this.shutdownTimes.incrementAndGet());
          • if (!this.hasShutdown) { - this.hasShutdown = true; - long begineTime = System.currentTimeMillis(); - controller.shutdown(); - long consumingTimeTotal = System.currentTimeMillis() - begineTime; - log.info("shutdown hook over, consuming time total(ms): " + consumingTimeTotal); - }
          • }
            + public Object call() throws Exception {
              • End diff –

          @WillemJiang done.

          Show
          githubbot ASF GitHub Bot added a comment - Github user wu-sheng commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/34#discussion_r95546560 — Diff: filtersrv/src/main/java/org/apache/rocketmq/filtersrv/FiltersrvStartup.java — @@ -135,27 +137,17 @@ public static FiltersrvController createController(String[] args) { System.exit(-3); } Runtime.getRuntime().addShutdownHook(new Thread(new Runnable() { private volatile boolean hasShutdown = false; private AtomicInteger shutdownTimes = new AtomicInteger(0); - + Runtime.getRuntime().addShutdownHook(new ShutdownHookThread(log, new Callable() { @Override public void run() { synchronized (this) { log.info("shutdown hook was invoked, " + this.shutdownTimes.incrementAndGet()); if (!this.hasShutdown) { - this.hasShutdown = true; - long begineTime = System.currentTimeMillis(); - controller.shutdown(); - long consumingTimeTotal = System.currentTimeMillis() - begineTime; - log.info("shutdown hook over, consuming time total(ms): " + consumingTimeTotal); - } } + public Object call() throws Exception { End diff – @WillemJiang done.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zhouxinyu commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/34

          It could be better if we add some unit tests for this PR and please remove the author info.

          Show
          githubbot ASF GitHub Bot added a comment - Github user zhouxinyu commented on the issue: https://github.com/apache/incubator-rocketmq/pull/34 It could be better if we add some unit tests for this PR and please remove the author info.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user coveralls commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/34

          [![Coverage Status](https://coveralls.io/builds/9761169/badge)](https://coveralls.io/builds/9761169)

          Changes Unknown when pulling *68f64b643f795b34e8a2300475ca4f5fca52f53e on wu-sheng:fix/ROCKETMQ-39* into ** on apache:master**.

          Show
          githubbot ASF GitHub Bot added a comment - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/34 [! [Coverage Status] ( https://coveralls.io/builds/9761169/badge)](https://coveralls.io/builds/9761169 ) Changes Unknown when pulling * 68f64b643f795b34e8a2300475ca4f5fca52f53e on wu-sheng:fix/ ROCKETMQ-39 * into ** on apache:master**.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user coveralls commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/34

          [![Coverage Status](https://coveralls.io/builds/9761169/badge)](https://coveralls.io/builds/9761169)

          Changes Unknown when pulling *68f64b643f795b34e8a2300475ca4f5fca52f53e on wu-sheng:fix/ROCKETMQ-39* into ** on apache:master**.

          Show
          githubbot ASF GitHub Bot added a comment - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/34 [! [Coverage Status] ( https://coveralls.io/builds/9761169/badge)](https://coveralls.io/builds/9761169 ) Changes Unknown when pulling * 68f64b643f795b34e8a2300475ca4f5fca52f53e on wu-sheng:fix/ ROCKETMQ-39 * into ** on apache:master**.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user coveralls commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/34

          [![Coverage Status](https://coveralls.io/builds/9761169/badge)](https://coveralls.io/builds/9761169)

          Changes Unknown when pulling *68f64b643f795b34e8a2300475ca4f5fca52f53e on wu-sheng:fix/ROCKETMQ-39* into ** on apache:master**.

          Show
          githubbot ASF GitHub Bot added a comment - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/34 [! [Coverage Status] ( https://coveralls.io/builds/9761169/badge)](https://coveralls.io/builds/9761169 ) Changes Unknown when pulling * 68f64b643f795b34e8a2300475ca4f5fca52f53e on wu-sheng:fix/ ROCKETMQ-39 * into ** on apache:master**.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user WillemJiang commented on a diff in the pull request:

          https://github.com/apache/incubator-rocketmq/pull/34#discussion_r97189548

          — Diff: filtersrv/src/main/java/org/apache/rocketmq/filtersrv/FiltersrvStartup.java —
          @@ -139,7 +139,7 @@ public static FiltersrvController createController(String[] args) {

          Runtime.getRuntime().addShutdownHook(new ShutdownHookThread(log, new Callable() {
          @Override

          • public Object call() throws Exception {
            + public Void call() throws Exception {
            controller.shutdown();
            return null;
              • End diff –

          When use the Void as the return signature, you don't need to use return in the function.
          Please remove the line of 144.

          Show
          githubbot ASF GitHub Bot added a comment - Github user WillemJiang commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/34#discussion_r97189548 — Diff: filtersrv/src/main/java/org/apache/rocketmq/filtersrv/FiltersrvStartup.java — @@ -139,7 +139,7 @@ public static FiltersrvController createController(String[] args) { Runtime.getRuntime().addShutdownHook(new ShutdownHookThread(log, new Callable() { @Override public Object call() throws Exception { + public Void call() throws Exception { controller.shutdown(); return null; End diff – When use the Void as the return signature, you don't need to use return in the function. Please remove the line of 144.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user WillemJiang commented on a diff in the pull request:

          https://github.com/apache/incubator-rocketmq/pull/34#discussion_r97189560

          — Diff: namesrv/src/main/java/org/apache/rocketmq/namesrv/NamesrvStartup.java —
          @@ -123,7 +123,7 @@ public static NamesrvController main0(String[] args) {

          Runtime.getRuntime().addShutdownHook(new ShutdownHookThread(log, new Callable() {
          @Override

          • public Object call() throws Exception {
            + public Void call() throws Exception {
            controller.shutdown();
            return null;
              • End diff –

          This line should be removed.

          Show
          githubbot ASF GitHub Bot added a comment - Github user WillemJiang commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/34#discussion_r97189560 — Diff: namesrv/src/main/java/org/apache/rocketmq/namesrv/NamesrvStartup.java — @@ -123,7 +123,7 @@ public static NamesrvController main0(String[] args) { Runtime.getRuntime().addShutdownHook(new ShutdownHookThread(log, new Callable() { @Override public Object call() throws Exception { + public Void call() throws Exception { controller.shutdown(); return null; End diff – This line should be removed.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user wu-sheng commented on a diff in the pull request:

          https://github.com/apache/incubator-rocketmq/pull/34#discussion_r97197140

          — Diff: filtersrv/src/main/java/org/apache/rocketmq/filtersrv/FiltersrvStartup.java —
          @@ -139,7 +139,7 @@ public static FiltersrvController createController(String[] args) {

          Runtime.getRuntime().addShutdownHook(new ShutdownHookThread(log, new Callable() {
          @Override

          • public Object call() throws Exception {
            + public Void call() throws Exception {
            controller.shutdown();
            return null;
              • End diff –

          @WillemJiang, Are you sure about no need `return null`? I have run a `mvn package` on local, and you can see, `return statement` is required.

          ```
          [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.5.1:compile (default-compile) on project rocketmq-namesrv: Compilation failure
          [ERROR] /Users/wusheng/Documents/code/github/incubator-rocketmq-fork/namesrv/src/main/java/org/apache/rocketmq/namesrv/NamesrvStartup.java:[128,17] 缺少返回语句
          [ERROR] -> [Help 1]
          ```

          Show
          githubbot ASF GitHub Bot added a comment - Github user wu-sheng commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/34#discussion_r97197140 — Diff: filtersrv/src/main/java/org/apache/rocketmq/filtersrv/FiltersrvStartup.java — @@ -139,7 +139,7 @@ public static FiltersrvController createController(String[] args) { Runtime.getRuntime().addShutdownHook(new ShutdownHookThread(log, new Callable() { @Override public Object call() throws Exception { + public Void call() throws Exception { controller.shutdown(); return null; End diff – @WillemJiang, Are you sure about no need `return null`? I have run a `mvn package` on local, and you can see, `return statement` is required. ``` [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.5.1:compile (default-compile) on project rocketmq-namesrv: Compilation failure [ERROR] /Users/wusheng/Documents/code/github/incubator-rocketmq-fork/namesrv/src/main/java/org/apache/rocketmq/namesrv/NamesrvStartup.java: [128,17] 缺少返回语句 [ERROR] -> [Help 1] ```
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user coveralls commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/34

          [![Coverage Status](https://coveralls.io/builds/9780368/badge)](https://coveralls.io/builds/9780368)

          Changes Unknown when pulling *c81c912526c4daf7ca01a187e8a181e605bc1824 on wu-sheng:fix/ROCKETMQ-39* into ** on apache:master**.

          Show
          githubbot ASF GitHub Bot added a comment - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/34 [! [Coverage Status] ( https://coveralls.io/builds/9780368/badge)](https://coveralls.io/builds/9780368 ) Changes Unknown when pulling * c81c912526c4daf7ca01a187e8a181e605bc1824 on wu-sheng:fix/ ROCKETMQ-39 * into ** on apache:master**.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user coveralls commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/34

          [![Coverage Status](https://coveralls.io/builds/9780368/badge)](https://coveralls.io/builds/9780368)

          Changes Unknown when pulling *c81c912526c4daf7ca01a187e8a181e605bc1824 on wu-sheng:fix/ROCKETMQ-39* into ** on apache:master**.

          Show
          githubbot ASF GitHub Bot added a comment - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/34 [! [Coverage Status] ( https://coveralls.io/builds/9780368/badge)](https://coveralls.io/builds/9780368 ) Changes Unknown when pulling * c81c912526c4daf7ca01a187e8a181e605bc1824 on wu-sheng:fix/ ROCKETMQ-39 * into ** on apache:master**.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user coveralls commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/34

          [![Coverage Status](https://coveralls.io/builds/9780368/badge)](https://coveralls.io/builds/9780368)

          Changes Unknown when pulling *c81c912526c4daf7ca01a187e8a181e605bc1824 on wu-sheng:fix/ROCKETMQ-39* into ** on apache:master**.

          Show
          githubbot ASF GitHub Bot added a comment - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/34 [! [Coverage Status] ( https://coveralls.io/builds/9780368/badge)](https://coveralls.io/builds/9780368 ) Changes Unknown when pulling * c81c912526c4daf7ca01a187e8a181e605bc1824 on wu-sheng:fix/ ROCKETMQ-39 * into ** on apache:master**.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user WillemJiang commented on a diff in the pull request:

          https://github.com/apache/incubator-rocketmq/pull/34#discussion_r97214481

          — Diff: filtersrv/src/main/java/org/apache/rocketmq/filtersrv/FiltersrvStartup.java —
          @@ -139,7 +139,7 @@ public static FiltersrvController createController(String[] args) {

          Runtime.getRuntime().addShutdownHook(new ShutdownHookThread(log, new Callable() {
          @Override

          • public Object call() throws Exception {
            + public Void call() throws Exception {
            controller.shutdown();
            return null;
              • End diff –

          @wu-sheng , oh, it's my mistake, I just wrote a code and the return statement need to be kept.
          As I'm not a big fan of null, I always want to kill it if possible.

          Show
          githubbot ASF GitHub Bot added a comment - Github user WillemJiang commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/34#discussion_r97214481 — Diff: filtersrv/src/main/java/org/apache/rocketmq/filtersrv/FiltersrvStartup.java — @@ -139,7 +139,7 @@ public static FiltersrvController createController(String[] args) { Runtime.getRuntime().addShutdownHook(new ShutdownHookThread(log, new Callable() { @Override public Object call() throws Exception { + public Void call() throws Exception { controller.shutdown(); return null; End diff – @wu-sheng , oh, it's my mistake, I just wrote a code and the return statement need to be kept. As I'm not a big fan of null, I always want to kill it if possible.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user wu-sheng commented on a diff in the pull request:

          https://github.com/apache/incubator-rocketmq/pull/34#discussion_r97214517

          — Diff: filtersrv/src/main/java/org/apache/rocketmq/filtersrv/FiltersrvStartup.java —
          @@ -139,7 +139,7 @@ public static FiltersrvController createController(String[] args) {

          Runtime.getRuntime().addShutdownHook(new ShutdownHookThread(log, new Callable() {
          @Override

          • public Object call() throws Exception {
            + public Void call() throws Exception {
            controller.shutdown();
            return null;
              • End diff –

          +1 on `kill return`, sadly, it's not working.

          Show
          githubbot ASF GitHub Bot added a comment - Github user wu-sheng commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/34#discussion_r97214517 — Diff: filtersrv/src/main/java/org/apache/rocketmq/filtersrv/FiltersrvStartup.java — @@ -139,7 +139,7 @@ public static FiltersrvController createController(String[] args) { Runtime.getRuntime().addShutdownHook(new ShutdownHookThread(log, new Callable() { @Override public Object call() throws Exception { + public Void call() throws Exception { controller.shutdown(); return null; End diff – +1 on `kill return`, sadly, it's not working.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit c0fe02e1c6a0afd516c1323c8b5808fd7ddad72e in incubator-rocketmq's branch refs/heads/develop from wu-sheng
          [ https://git-wip-us.apache.org/repos/asf?p=incubator-rocketmq.git;h=c0fe02e ]

          ROCKETMQ-39 avoid duplicated codes closes apache/incubator-rocketmq#34

          Show
          jira-bot ASF subversion and git services added a comment - Commit c0fe02e1c6a0afd516c1323c8b5808fd7ddad72e in incubator-rocketmq's branch refs/heads/develop from wu-sheng [ https://git-wip-us.apache.org/repos/asf?p=incubator-rocketmq.git;h=c0fe02e ] ROCKETMQ-39 avoid duplicated codes closes apache/incubator-rocketmq#34
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user dongeforever commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/34

          @wu-sheng this PR has been merged. you may close the PR.

          Show
          githubbot ASF GitHub Bot added a comment - Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/34 @wu-sheng this PR has been merged. you may close the PR.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/incubator-rocketmq/pull/34

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/incubator-rocketmq/pull/34

            People

            • Assignee:
              vintagewang Xiaorui Wang
              Reporter:
              wu-sheng Wu Sheng
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development