Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0.0-incubating
    • Component/s: None
    • Labels:
      None

      Description

      1. in MQClientManager#getAndCreateMQClientInstance line 57
      when generate a new key-value pair for client in factoryTable, if there was no mapping for the clientId previously, putIfAbsent will return null, and then output:
      "log.warn("Previous MQClientInstance has created for clientId:[{}]", clientId);"
      this is wrong, it should output in condition prev != null

      2. in SubscriptionGroupManager#deleteSubscriptionGroupConfig line 187
      if program execute:
      log.warn("delete subscription group failed, subscription group: {} not exist", old);
      variable old is always null , it's useless, so it's better to print groupName

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                vongosling vongosling
                Reporter:
                qianzhenyu QianZhenyu
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: