[ROCKETMQ-360] RouteInfoManager scanNotActiveBroker not protect by lock

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 4.2.0
• Component/s: rocketmq-namesrv
• Assignee: Xinyu Zhou
• Reporter: zhaoziyan
• Created: 24/Jan/18 07:51
• Updated: 24/Jan/18 15:18

Description

// code placeholder
public void scanNotActiveBroker() {
Iterator<Entry<String, BrokerLiveInfo>> it = this.brokerLiveTable.entrySet().iterator();
while (it.hasNext()) {
Entry<String, BrokerLiveInfo> next = it.next();
long last = next.getValue().getLastUpdateTimestamp();
if ((last + BROKER_CHANNEL_EXPIRED_TIME) < System.currentTimeMillis()) {
RemotingUtil.closeChannel(next.getValue().getChannel());
it.remove();
log.warn("The broker channel expired, {} {}ms", next.getKey(), BROKER_CHANNEL_EXPIRED_TIME);
this.onChannelDestroy(next.getKey(), next.getValue().getChannel());
}
}
}

it.remove() not in lock .may cause the sche thread down