Uploaded image for project: 'Apache RocketMQ'
  1. Apache RocketMQ
  2. ROCKETMQ-30

Message Filter example has incorrect method signature

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0.0-incubating
    • Component/s: None
    • Labels:
      None

      Description

      org.apache.rocketmq.example.filter.MessageFilterImpl has public boolean match(MessageExt msg) while the correct one is public boolean match(MessageExt msg, FilterContext context). Therefore it fails to compile and load with DynaCode.

      Additionally, org.apache.rocketmq.example.filter.Consumer refers to the path that normally may not exist on users' machines /home/admin/. It should be changed to the resources/ where MessageFilterImpl is placed.

        Issue Links

          Activity

          Hide
          roman_s Roman Shtykh added a comment -

          Additionally, I will change the topic to TopicTest so that anyone can test the filter on events inserted using org.apache.rocketmq.example.quickstart.Producer
          http://rocketmq.apache.org/docs/quick-start/

          Show
          roman_s Roman Shtykh added a comment - Additionally, I will change the topic to TopicTest so that anyone can test the filter on events inserted using org.apache.rocketmq.example.quickstart.Producer http://rocketmq.apache.org/docs/quick-start/
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user shroman opened a pull request:

          https://github.com/apache/incubator-rocketmq/pull/27

          ROCKETMQ-30 Fixed method signature for Message Filter example and c…

          …lass loading from resources/

          JIRA issue: https://issues.apache.org/jira/browse/ROCKETMQ-30

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/shroman/incubator-rocketmq ROCKETMQ-30

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/incubator-rocketmq/pull/27.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #27


          commit fd99f12c32d2c44400c45ce5b53903b1f78558c5
          Author: shtykh_roman <rshtykh@yahoo.com>
          Date: 2017-01-05T01:58:50Z

          ROCKETMQ-30 Fixed method signature for Message Filter example and class loading from resources/

          JIRA issue: https://issues.apache.org/jira/browse/ROCKETMQ-30


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user shroman opened a pull request: https://github.com/apache/incubator-rocketmq/pull/27 ROCKETMQ-30 Fixed method signature for Message Filter example and c… …lass loading from resources/ JIRA issue: https://issues.apache.org/jira/browse/ROCKETMQ-30 You can merge this pull request into a Git repository by running: $ git pull https://github.com/shroman/incubator-rocketmq ROCKETMQ-30 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-rocketmq/pull/27.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #27 commit fd99f12c32d2c44400c45ce5b53903b1f78558c5 Author: shtykh_roman <rshtykh@yahoo.com> Date: 2017-01-05T01:58:50Z ROCKETMQ-30 Fixed method signature for Message Filter example and class loading from resources/ JIRA issue: https://issues.apache.org/jira/browse/ROCKETMQ-30
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user shroman commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/27

          @vongosling @zhouxinyu Completed and ready for review.

          Show
          githubbot ASF GitHub Bot added a comment - Github user shroman commented on the issue: https://github.com/apache/incubator-rocketmq/pull/27 @vongosling @zhouxinyu Completed and ready for review.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zhouxinyu commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/27

          Cool, thanks @shroman

          Show
          githubbot ASF GitHub Bot added a comment - Github user zhouxinyu commented on the issue: https://github.com/apache/incubator-rocketmq/pull/27 Cool, thanks @shroman
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user vongosling commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/27

          alright

          Show
          githubbot ASF GitHub Bot added a comment - Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq/pull/27 alright
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 1562bd0d11fbf4bbbca38921c6cc07ebe11ea15a in incubator-rocketmq's branch refs/heads/master from shroman
          [ https://git-wip-us.apache.org/repos/asf?p=incubator-rocketmq.git;h=1562bd0 ]

          ROCKETMQ-30 Fixed method signature for Message Filter example and class loading from resources, closes apache/incubator-rocketmq#27

          Show
          jira-bot ASF subversion and git services added a comment - Commit 1562bd0d11fbf4bbbca38921c6cc07ebe11ea15a in incubator-rocketmq's branch refs/heads/master from shroman [ https://git-wip-us.apache.org/repos/asf?p=incubator-rocketmq.git;h=1562bd0 ] ROCKETMQ-30 Fixed method signature for Message Filter example and class loading from resources, closes apache/incubator-rocketmq#27
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/incubator-rocketmq/pull/27

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/incubator-rocketmq/pull/27

            People

            • Assignee:
              roman_s Roman Shtykh
              Reporter:
              roman_s Roman Shtykh
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development