[ROCKETMQ-234] Bugfix in batch scenario

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.1.0-incubating, 4.2.0
• Fix Version/s: 4.2.0
• Component/s: rocketmq-broker
• Assignee: Xinyu Zhou
• Reporter: Yu Kaiyuan
• Created: 27/Jun/17 12:44
• Updated: 01/Aug/17 07:26
• Resolved: 03/Jul/17 10:00

Description

Bug in handle batch response. Broker will write response twice to client in batch scenario.
Details below:

private RemotingCommand sendBatchMessage(...)
{
    // ignore irrelevant logic...
    // here in handlePutMessageResult function, reponse will be written back through ctx once
    handlePutMessageResult(putMessageResult, response, request, messageExtBatch, responseHeader, sendMessageContext, ctx, queueIdInt);
    // the response returned here will be written back again if response is not null 
    return response;
}

Issue Links

• links to: GitHub Pull Request #128