Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Duplicate
    • Affects Version/s: 4.0.0-incubating
    • Fix Version/s: 4.0.0-incubating
    • Component/s: rocketmq-client
    • Labels:
      None

      Description

      LinkedList.add() is not thread-safe, so it must be synchronized externally when using concurrently.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user Zhang-Ke opened a pull request:

          https://github.com/apache/incubator-rocketmq/pull/16

          [Rocketmq 19] Thread-unsafe in MQAdminImpl#queryMessage

          Thread-unsafe in MQAdminImpl#queryMessage

          JIRRA ISSUE: https://issues.apache.org/jira/browse/ROCKETMQ-19(url)

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/Zhang-Ke/incubator-rocketmq ROCKETMQ-19

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/incubator-rocketmq/pull/16.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #16


          commit 360341e56da3dfed2c5175e99a599aff9e772a3e
          Author: zhendongliu.lzd <zhendongliu.lzd@alibaba-inc.com>
          Date: 2016-12-26T02:31:45Z

          ROCKETMQ-3 Remove try...catch, using assertNull etc

          commit f1552f6e66b283bdd429cd4fc82fb9046a20f868
          Author: shtykh_roman <rshtykh@yahoo.com>
          Date: 2016-12-26T03:17:53Z

          ROCKETMQ-13 Wrong log level for AcceptSocketService termination.

          Additionally, added code comments and did a cleanup.

          JIRA issue: https://issues.apache.org/jira/browse/ROCKETMQ-13

          commit 9adebcce37cf08f09cd36f34b6571dde5df52b7c
          Author: zhangke <zhangke_beijing@qq.com>
          Date: 2016-12-27T09:53:23Z

          ROCKETMQ-19 Synchronize LinkedList in multi-thread


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user Zhang-Ke opened a pull request: https://github.com/apache/incubator-rocketmq/pull/16 [Rocketmq 19] Thread-unsafe in MQAdminImpl#queryMessage Thread-unsafe in MQAdminImpl#queryMessage JIRRA ISSUE: https://issues.apache.org/jira/browse/ROCKETMQ-19 (url) You can merge this pull request into a Git repository by running: $ git pull https://github.com/Zhang-Ke/incubator-rocketmq ROCKETMQ-19 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-rocketmq/pull/16.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #16 commit 360341e56da3dfed2c5175e99a599aff9e772a3e Author: zhendongliu.lzd <zhendongliu.lzd@alibaba-inc.com> Date: 2016-12-26T02:31:45Z ROCKETMQ-3 Remove try...catch, using assertNull etc commit f1552f6e66b283bdd429cd4fc82fb9046a20f868 Author: shtykh_roman <rshtykh@yahoo.com> Date: 2016-12-26T03:17:53Z ROCKETMQ-13 Wrong log level for AcceptSocketService termination. Additionally, added code comments and did a cleanup. JIRA issue: https://issues.apache.org/jira/browse/ROCKETMQ-13 commit 9adebcce37cf08f09cd36f34b6571dde5df52b7c Author: zhangke <zhangke_beijing@qq.com> Date: 2016-12-27T09:53:23Z ROCKETMQ-19 Synchronize LinkedList in multi-thread
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Zhang-Ke closed the pull request at:

          https://github.com/apache/incubator-rocketmq/pull/16

          Show
          githubbot ASF GitHub Bot added a comment - Github user Zhang-Ke closed the pull request at: https://github.com/apache/incubator-rocketmq/pull/16
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user Zhang-Ke opened a pull request:

          https://github.com/apache/incubator-rocketmq/pull/17

          ROCKETMQ-19 Synchronize LinkedList.add() in multi-thread

          ROCKETMQ-19 Synchronize LinkedList.add() in multi-thread

          JIRRA ISSUE: https://issues.apache.org/jira/browse/ROCKETMQ-19(url)

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/Zhang-Ke/incubator-rocketmq ROCKETMQ-19

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/incubator-rocketmq/pull/17.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #17


          commit 0abd5265aa11df31492412d15192628b3f46ecc2
          Author: zhangke <zhangke_beijing@qq.com>
          Date: 2016-12-27T10:21:18Z

          ROCKETMQ-19 Synchronize LinkedList.add() in multi-thread


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user Zhang-Ke opened a pull request: https://github.com/apache/incubator-rocketmq/pull/17 ROCKETMQ-19 Synchronize LinkedList.add() in multi-thread ROCKETMQ-19 Synchronize LinkedList.add() in multi-thread JIRRA ISSUE: https://issues.apache.org/jira/browse/ROCKETMQ-19 (url) You can merge this pull request into a Git repository by running: $ git pull https://github.com/Zhang-Ke/incubator-rocketmq ROCKETMQ-19 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-rocketmq/pull/17.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #17 commit 0abd5265aa11df31492412d15192628b3f46ecc2 Author: zhangke <zhangke_beijing@qq.com> Date: 2016-12-27T10:21:18Z ROCKETMQ-19 Synchronize LinkedList.add() in multi-thread
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user lollipopjin commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/17

          @Zhang-Ke Thanks for your PR, Could you please verify mentioned problem, no matter using unit or other ways. At last, please fix the conflict problem.

          Show
          githubbot ASF GitHub Bot added a comment - Github user lollipopjin commented on the issue: https://github.com/apache/incubator-rocketmq/pull/17 @Zhang-Ke Thanks for your PR, Could you please verify mentioned problem, no matter using unit or other ways. At last, please fix the conflict problem.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Zhang-Ke commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/17

          Duplicated with https://github.com/apache/incubator-rocketmq/pull/22PR #22 (url)

          Show
          githubbot ASF GitHub Bot added a comment - Github user Zhang-Ke commented on the issue: https://github.com/apache/incubator-rocketmq/pull/17 Duplicated with https://github.com/apache/incubator-rocketmq/pull/22 PR #22 (url)
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Zhang-Ke closed the pull request at:

          https://github.com/apache/incubator-rocketmq/pull/17

          Show
          githubbot ASF GitHub Bot added a comment - Github user Zhang-Ke closed the pull request at: https://github.com/apache/incubator-rocketmq/pull/17
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user vongosling commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/17

          Thanks for your ISSUE review before PR @Zhang-Ke

          Show
          githubbot ASF GitHub Bot added a comment - Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq/pull/17 Thanks for your ISSUE review before PR @Zhang-Ke

            People

            • Assignee:
              vintagewang Xiaorui Wang
              Reporter:
              zhangke Rich Zhang
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development