Uploaded image for project: 'Apache RocketMQ'
  1. Apache RocketMQ
  2. ROCKETMQ-188

RemotingExecption is not consistent between invoke async and invoke oneway

    Details

      Description

      For existing invoke oneway code base, RemotingTooMuchRequestException will be thrown only when timeout millis <0, otherwise, RemotingTimeoutException will be thrown.

      But in invokeAsync, RemotingTooMuchRequestException is always thrown no matter what value the timeout millis , which is inconsistent. Besides, the RemotingTimeoutException is declared in the signature but it will be never thrown.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user Jaskey opened a pull request:

          https://github.com/apache/incubator-rocketmq/pull/98

          ROCKETMQ-188RemotingExecption is not consistent between invoke async and invoke oneway

          JIRA: https://issues.apache.org/jira/browse/ROCKETMQ-188

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/Jaskey/incubator-rocketmq ROCKETMQ-188-remoting-exception-inconsistent

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/incubator-rocketmq/pull/98.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #98


          commit ec2d4ac140fab8812066a7184f9e21ea0b879191
          Author: Jaskey <linjunjie1103@gmail.com>
          Date: 2017-04-25T03:00:51Z

          Make exception of invokeAsync is consitent of invokeOneway


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user Jaskey opened a pull request: https://github.com/apache/incubator-rocketmq/pull/98 ROCKETMQ-188 RemotingExecption is not consistent between invoke async and invoke oneway JIRA: https://issues.apache.org/jira/browse/ROCKETMQ-188 You can merge this pull request into a Git repository by running: $ git pull https://github.com/Jaskey/incubator-rocketmq ROCKETMQ-188 -remoting-exception-inconsistent Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-rocketmq/pull/98.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #98 commit ec2d4ac140fab8812066a7184f9e21ea0b879191 Author: Jaskey <linjunjie1103@gmail.com> Date: 2017-04-25T03:00:51Z Make exception of invokeAsync is consitent of invokeOneway
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user coveralls commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/98

          [![Coverage Status](https://coveralls.io/builds/11225316/badge)](https://coveralls.io/builds/11225316)

          Coverage increased (+0.04%) to 37.893% when pulling *ec2d4ac140fab8812066a7184f9e21ea0b879191 on Jaskey:ROCKETMQ-188-remoting-exception-inconsistent* into *6a9628b3c3e6835e37baf7b58ad9300364d4d384 on apache:develop*.

          Show
          githubbot ASF GitHub Bot added a comment - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/98 [! [Coverage Status] ( https://coveralls.io/builds/11225316/badge)](https://coveralls.io/builds/11225316 ) Coverage increased (+0.04%) to 37.893% when pulling * ec2d4ac140fab8812066a7184f9e21ea0b879191 on Jaskey: ROCKETMQ-188 -remoting-exception-inconsistent * into * 6a9628b3c3e6835e37baf7b58ad9300364d4d384 on apache:develop *.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Jaskey commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/98

          @lizhanhui @zhouxinyu @shroman
          guys, anyone helps review this pr?

          Show
          githubbot ASF GitHub Bot added a comment - Github user Jaskey commented on the issue: https://github.com/apache/incubator-rocketmq/pull/98 @lizhanhui @zhouxinyu @shroman guys, anyone helps review this pr?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user dongeforever commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/98

          LGTM @zhouxinyu @vongosling

          Show
          githubbot ASF GitHub Bot added a comment - Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/98 LGTM @zhouxinyu @vongosling
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zhouxinyu commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/98

          LGTM~, thanks @Jaskey

          Show
          githubbot ASF GitHub Bot added a comment - Github user zhouxinyu commented on the issue: https://github.com/apache/incubator-rocketmq/pull/98 LGTM~, thanks @Jaskey
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 8c8610f9121d19bf7108903e41276d5f6afaa81a in incubator-rocketmq's branch refs/heads/develop from Jaskey Lam
          [ https://git-wip-us.apache.org/repos/asf?p=incubator-rocketmq.git;h=8c8610f ]

          ROCKETMQ-188RemotingExecption is not consistent between invoke async and invoke oneway closes apache/incubator-rocketmq#98

          Show
          jira-bot ASF subversion and git services added a comment - Commit 8c8610f9121d19bf7108903e41276d5f6afaa81a in incubator-rocketmq's branch refs/heads/develop from Jaskey Lam [ https://git-wip-us.apache.org/repos/asf?p=incubator-rocketmq.git;h=8c8610f ] ROCKETMQ-188 RemotingExecption is not consistent between invoke async and invoke oneway closes apache/incubator-rocketmq#98
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 7ab59a335d4745fef92d6ba8b5df14dfd179ea80 in incubator-rocketmq's branch refs/heads/master from Jaskey Lam
          [ https://git-wip-us.apache.org/repos/asf?p=incubator-rocketmq.git;h=7ab59a3 ]

          ROCKETMQ-188RemotingExecption is not consistent between invoke async and invoke oneway closes apache/incubator-rocketmq#98

          Show
          jira-bot ASF subversion and git services added a comment - Commit 7ab59a335d4745fef92d6ba8b5df14dfd179ea80 in incubator-rocketmq's branch refs/heads/master from Jaskey Lam [ https://git-wip-us.apache.org/repos/asf?p=incubator-rocketmq.git;h=7ab59a3 ] ROCKETMQ-188 RemotingExecption is not consistent between invoke async and invoke oneway closes apache/incubator-rocketmq#98
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/incubator-rocketmq/pull/98

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/incubator-rocketmq/pull/98

            People

            • Assignee:
              Jaskey Jaskey Lam
              Reporter:
              Jaskey Jaskey Lam
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development