Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 4.1.0-incubating
    • Fix Version/s: 4.1.0-incubating
    • Component/s: rocketmq-broker
    • Labels:
      None

      Description

      Broker command line are supposed to support -m -p options to print out important settings. Now the logger is set as null, thus, no output at all.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user lizhanhui opened a pull request:

          https://github.com/apache/incubator-rocketmq/pull/93

          ROCKETMQ-178 Fix -p -m options

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/lizhanhui/incubator-rocketmq ROCKETMQ-178

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/incubator-rocketmq/pull/93.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #93


          commit 08e0fd18460510cdb6500067addfaf21dbe7a1c8
          Author: Li Zhanhui <lizhanhui@apache.org>
          Date: 2017-04-17T02:04:54Z

          Fix -p -m options


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user lizhanhui opened a pull request: https://github.com/apache/incubator-rocketmq/pull/93 ROCKETMQ-178 Fix -p -m options You can merge this pull request into a Git repository by running: $ git pull https://github.com/lizhanhui/incubator-rocketmq ROCKETMQ-178 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-rocketmq/pull/93.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #93 commit 08e0fd18460510cdb6500067addfaf21dbe7a1c8 Author: Li Zhanhui <lizhanhui@apache.org> Date: 2017-04-17T02:04:54Z Fix -p -m options
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user coveralls commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/93

          [![Coverage Status](https://coveralls.io/builds/11106131/badge)](https://coveralls.io/builds/11106131)

          Coverage decreased (-0.4%) to 34.204% when pulling *08e0fd18460510cdb6500067addfaf21dbe7a1c8 on lizhanhui:ROCKETMQ-178* into *7bcb3b3eae1e3c441861f2a3cd79ff54a8e691b9 on apache:develop*.

          Show
          githubbot ASF GitHub Bot added a comment - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/93 [! [Coverage Status] ( https://coveralls.io/builds/11106131/badge)](https://coveralls.io/builds/11106131 ) Coverage decreased (-0.4%) to 34.204% when pulling * 08e0fd18460510cdb6500067addfaf21dbe7a1c8 on lizhanhui: ROCKETMQ-178 * into * 7bcb3b3eae1e3c441861f2a3cd79ff54a8e691b9 on apache:develop *.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user lizhanhui commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/93

          > No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself. Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received

          One of the build failed, anyway to trigger restart the build? I do not have the permission to operate on this repo @vongosling

          Show
          githubbot ASF GitHub Bot added a comment - Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq/pull/93 > No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself. Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received One of the build failed, anyway to trigger restart the build? I do not have the permission to operate on this repo @vongosling
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user lizhanhui closed the pull request at:

          https://github.com/apache/incubator-rocketmq/pull/93

          Show
          githubbot ASF GitHub Bot added a comment - Github user lizhanhui closed the pull request at: https://github.com/apache/incubator-rocketmq/pull/93
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user lizhanhui reopened a pull request:

          https://github.com/apache/incubator-rocketmq/pull/93

          ROCKETMQ-178 Fix -p -m options

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/lizhanhui/incubator-rocketmq ROCKETMQ-178

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/incubator-rocketmq/pull/93.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #93


          commit 08e0fd18460510cdb6500067addfaf21dbe7a1c8
          Author: Li Zhanhui <lizhanhui@apache.org>
          Date: 2017-04-17T02:04:54Z

          Fix -p -m options


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user lizhanhui reopened a pull request: https://github.com/apache/incubator-rocketmq/pull/93 ROCKETMQ-178 Fix -p -m options You can merge this pull request into a Git repository by running: $ git pull https://github.com/lizhanhui/incubator-rocketmq ROCKETMQ-178 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-rocketmq/pull/93.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #93 commit 08e0fd18460510cdb6500067addfaf21dbe7a1c8 Author: Li Zhanhui <lizhanhui@apache.org> Date: 2017-04-17T02:04:54Z Fix -p -m options
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user coveralls commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/93

          [![Coverage Status](https://coveralls.io/builds/11106432/badge)](https://coveralls.io/builds/11106432)

          Coverage decreased (-0.03%) to 34.591% when pulling *08e0fd18460510cdb6500067addfaf21dbe7a1c8 on lizhanhui:ROCKETMQ-178* into *7bcb3b3eae1e3c441861f2a3cd79ff54a8e691b9 on apache:develop*.

          Show
          githubbot ASF GitHub Bot added a comment - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/93 [! [Coverage Status] ( https://coveralls.io/builds/11106432/badge)](https://coveralls.io/builds/11106432 ) Coverage decreased (-0.03%) to 34.591% when pulling * 08e0fd18460510cdb6500067addfaf21dbe7a1c8 on lizhanhui: ROCKETMQ-178 * into * 7bcb3b3eae1e3c441861f2a3cd79ff54a8e691b9 on apache:develop *.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user coveralls commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/93

          [![Coverage Status](https://coveralls.io/builds/11106432/badge)](https://coveralls.io/builds/11106432)

          Coverage decreased (-0.03%) to 34.591% when pulling *08e0fd18460510cdb6500067addfaf21dbe7a1c8 on lizhanhui:ROCKETMQ-178* into *7bcb3b3eae1e3c441861f2a3cd79ff54a8e691b9 on apache:develop*.

          Show
          githubbot ASF GitHub Bot added a comment - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/93 [! [Coverage Status] ( https://coveralls.io/builds/11106432/badge)](https://coveralls.io/builds/11106432 ) Coverage decreased (-0.03%) to 34.591% when pulling * 08e0fd18460510cdb6500067addfaf21dbe7a1c8 on lizhanhui: ROCKETMQ-178 * into * 7bcb3b3eae1e3c441861f2a3cd79ff54a8e691b9 on apache:develop *.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user vongosling commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/93

          Any trouble is still ?

          Show
          githubbot ASF GitHub Bot added a comment - Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq/pull/93 Any trouble is still ?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user lizhanhui commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/93

          > Any trouble is still ?

          No. It's a trivial change and should have been merged/closed.

          Show
          githubbot ASF GitHub Bot added a comment - Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq/pull/93 > Any trouble is still ? No. It's a trivial change and should have been merged/closed.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user dongeforever commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/93

          @lizhanhui I want to merge this PR. Could you please resolve the conflicting files?

          Show
          githubbot ASF GitHub Bot added a comment - Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/93 @lizhanhui I want to merge this PR. Could you please resolve the conflicting files?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user dongeforever commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/93

          LGTM, I will merge this PR

          Show
          githubbot ASF GitHub Bot added a comment - Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/93 LGTM, I will merge this PR
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 42826c4115d91ee48512df288b6fe3822af73f06 in incubator-rocketmq's branch refs/heads/develop from Li Zhanhui
          [ https://git-wip-us.apache.org/repos/asf?p=incubator-rocketmq.git;h=42826c4 ]

          ROCKETMQ-178 Fix -p -m options closes apache/incubator-rocketmq#93

          Show
          jira-bot ASF subversion and git services added a comment - Commit 42826c4115d91ee48512df288b6fe3822af73f06 in incubator-rocketmq's branch refs/heads/develop from Li Zhanhui [ https://git-wip-us.apache.org/repos/asf?p=incubator-rocketmq.git;h=42826c4 ] ROCKETMQ-178 Fix -p -m options closes apache/incubator-rocketmq#93
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user lizhanhui closed the pull request at:

          https://github.com/apache/incubator-rocketmq/pull/93

          Show
          githubbot ASF GitHub Bot added a comment - Github user lizhanhui closed the pull request at: https://github.com/apache/incubator-rocketmq/pull/93

            People

            • Assignee:
              lizhanhui Zhanhui Li
              Reporter:
              lizhanhui Zhanhui Li
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development