Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.1.0-incubating
    • Component/s: rocketmq-client
    • Labels:
      None

      Description

      rename pollNameServerInteval to pollNameServerInterval

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user vesense opened a pull request:

          https://github.com/apache/incubator-rocketmq/pull/84

          ROCKETMQ-155 fix typo in ClientConfig

          rename `pollNameServerInteval` to `pollNameServerInterval`

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/vesense/incubator-rocketmq ROCKETMQ-155

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/incubator-rocketmq/pull/84.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #84


          commit 0a3d270fa4627a3b5afca268b16de6db6e44f521
          Author: vesense <best.wangxin@163.com>
          Date: 2017-03-24T05:38:55Z

          ROCKETMQ-155 fix typo in ClientConfig


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user vesense opened a pull request: https://github.com/apache/incubator-rocketmq/pull/84 ROCKETMQ-155 fix typo in ClientConfig rename `pollNameServerInteval` to `pollNameServerInterval` You can merge this pull request into a Git repository by running: $ git pull https://github.com/vesense/incubator-rocketmq ROCKETMQ-155 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-rocketmq/pull/84.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #84 commit 0a3d270fa4627a3b5afca268b16de6db6e44f521 Author: vesense <best.wangxin@163.com> Date: 2017-03-24T05:38:55Z ROCKETMQ-155 fix typo in ClientConfig
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user coveralls commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/84

          [![Coverage Status](https://coveralls.io/builds/10752179/badge)](https://coveralls.io/builds/10752179)

          Coverage increased (+0.3%) to 31.785% when pulling *0a3d270fa4627a3b5afca268b16de6db6e44f521 on vesense:ROCKETMQ-155* into *15af63e23b8649537cce56a831c7f965451ce399 on apache:develop*.

          Show
          githubbot ASF GitHub Bot added a comment - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/84 [! [Coverage Status] ( https://coveralls.io/builds/10752179/badge)](https://coveralls.io/builds/10752179 ) Coverage increased (+0.3%) to 31.785% when pulling * 0a3d270fa4627a3b5afca268b16de6db6e44f521 on vesense: ROCKETMQ-155 * into * 15af63e23b8649537cce56a831c7f965451ce399 on apache:develop *.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user coveralls commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/84

          [![Coverage Status](https://coveralls.io/builds/10752179/badge)](https://coveralls.io/builds/10752179)

          Coverage increased (+0.3%) to 31.785% when pulling *0a3d270fa4627a3b5afca268b16de6db6e44f521 on vesense:ROCKETMQ-155* into *15af63e23b8649537cce56a831c7f965451ce399 on apache:develop*.

          Show
          githubbot ASF GitHub Bot added a comment - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/84 [! [Coverage Status] ( https://coveralls.io/builds/10752179/badge)](https://coveralls.io/builds/10752179 ) Coverage increased (+0.3%) to 31.785% when pulling * 0a3d270fa4627a3b5afca268b16de6db6e44f521 on vesense: ROCKETMQ-155 * into * 15af63e23b8649537cce56a831c7f965451ce399 on apache:develop *.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user lizhanhui commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/84

          Looks good.

          Show
          githubbot ASF GitHub Bot added a comment - Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq/pull/84 Looks good.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user vongosling commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/84

          LGTM,please @shroman @lizhanhui help to review it~

          Show
          githubbot ASF GitHub Bot added a comment - Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq/pull/84 LGTM,please @shroman @lizhanhui help to review it~
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user lizhanhui commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/84

          +1

          Show
          githubbot ASF GitHub Bot added a comment - Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq/pull/84 +1
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user shroman commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/84

          +1

          Show
          githubbot ASF GitHub Bot added a comment - Github user shroman commented on the issue: https://github.com/apache/incubator-rocketmq/pull/84 +1
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user lizhanhui commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/84

          This is quick fix of typo and we have collected three +1s. Now it's merged.

          Show
          githubbot ASF GitHub Bot added a comment - Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq/pull/84 This is quick fix of typo and we have collected three +1s. Now it's merged.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user lizhanhui commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/84

          @vesense Please close this issue at your convenient time.

          Show
          githubbot ASF GitHub Bot added a comment - Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq/pull/84 @vesense Please close this issue at your convenient time.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user vesense commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/84

          Thanks & Closed.

          Show
          githubbot ASF GitHub Bot added a comment - Github user vesense commented on the issue: https://github.com/apache/incubator-rocketmq/pull/84 Thanks & Closed.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user vesense closed the pull request at:

          https://github.com/apache/incubator-rocketmq/pull/84

          Show
          githubbot ASF GitHub Bot added a comment - Github user vesense closed the pull request at: https://github.com/apache/incubator-rocketmq/pull/84
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Jaskey commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/84

          We should have a compatibility notice and guide when releasing 4.1.

          Show
          githubbot ASF GitHub Bot added a comment - Github user Jaskey commented on the issue: https://github.com/apache/incubator-rocketmq/pull/84 We should have a compatibility notice and guide when releasing 4.1.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user lizhanhui commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/84

          Yes, best to have this change log.

          Show
          githubbot ASF GitHub Bot added a comment - Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq/pull/84 Yes, best to have this change log.

            People

            • Assignee:
              vesense Xin Wang
              Reporter:
              vesense Xin Wang
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development