Uploaded image for project: 'Apache RocketMQ'
  1. Apache RocketMQ
  2. ROCKETMQ-14

Remoting invoke callback shoule be invoked in an executor rather than in current thread.

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0.0-incubating
    • Component/s: None
    • Labels:
      None

      Description

      For success callback, processResponseCommand will execute invoke callback in a saparate executor rather than the time thread.

      But for timeout problem , the timeout callback will be invoked directly in timer thread/netty selector thread.

      If the user put some time-cost task when timeout, the other timeout callback will be blocked to schedule.

        Issue Links

          Activity

          Show
          Jaskey Jaskey Lam added a comment - github pr: https://github.com/apache/incubator-rocketmq/pull/2
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user vongosling commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/2

          Source code seems ok, please @zhouxinyu @lollipopjin review it

          Show
          githubbot ASF GitHub Bot added a comment - Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq/pull/2 Source code seems ok, please @zhouxinyu @lollipopjin review it
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/incubator-rocketmq/pull/2

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/incubator-rocketmq/pull/2
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zhouxinyu commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/2

          Hi,

          This PR has been merged, but next time please use JIRA issue name(`ROCKETMQ-14`) as branch name instead of `master`. Please refer to [here](http://rocketmq.apache.org/docs/pull-request/) for more details.

          Thanks.

          Show
          githubbot ASF GitHub Bot added a comment - Github user zhouxinyu commented on the issue: https://github.com/apache/incubator-rocketmq/pull/2 Hi, This PR has been merged, but next time please use JIRA issue name(` ROCKETMQ-14 `) as branch name instead of `master`. Please refer to [here] ( http://rocketmq.apache.org/docs/pull-request/ ) for more details. Thanks.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user vongosling commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/19

          IMO, we could close this pr without any more works @lollipopjin

          thanks @Jaskey

          Show
          githubbot ASF GitHub Bot added a comment - Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq/pull/19 IMO, we could close this pr without any more works @lollipopjin thanks @Jaskey
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/incubator-rocketmq/pull/19

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/incubator-rocketmq/pull/19
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Jaskey commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/19

          @vongosling Is there any problem on this unit test code?

          Show
          githubbot ASF GitHub Bot added a comment - Github user Jaskey commented on the issue: https://github.com/apache/incubator-rocketmq/pull/19 @vongosling Is there any problem on this unit test code?

            People

            • Assignee:
              vongosling vongosling
              Reporter:
              Jaskey Jaskey Lam
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development