Uploaded image for project: 'Apache RocketMQ'
  1. Apache RocketMQ
  2. ROCKETMQ-13

Wrong log level for AcceptSocketService termination

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0.0-incubating
    • Component/s: None
    • Labels:
      None

      Description

      Running com.alibaba.rocketmq.store.DefaultMessageStoreTest results in ERROR RocketmqStore - AcceptSocketService service end.

      But it terminates normally, the logger level has to be set to 'INFO'.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user shroman opened a pull request:

          https://github.com/apache/incubator-rocketmq/pull/12

          ROCKETMQ-13 Wrong log level for AcceptSocketService termination.

          Additionally, added code comments and did a cleanup.

          JIRA issue: https://issues.apache.org/jira/browse/ROCKETMQ-13

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/shroman/incubator-rocketmq ROCKETMQ-13

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/incubator-rocketmq/pull/12.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #12


          commit 6cb25ad15334fb00a3ba924d05b5419576f5219b
          Author: shtykh_roman <rshtykh@yahoo.com>
          Date: 2016-12-26T03:17:53Z

          ROCKETMQ-13 Wrong log level for AcceptSocketService termination.

          Additionally, added code comments and did a cleanup.

          JIRA issue: https://issues.apache.org/jira/browse/ROCKETMQ-13


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user shroman opened a pull request: https://github.com/apache/incubator-rocketmq/pull/12 ROCKETMQ-13 Wrong log level for AcceptSocketService termination. Additionally, added code comments and did a cleanup. JIRA issue: https://issues.apache.org/jira/browse/ROCKETMQ-13 You can merge this pull request into a Git repository by running: $ git pull https://github.com/shroman/incubator-rocketmq ROCKETMQ-13 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-rocketmq/pull/12.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #12 commit 6cb25ad15334fb00a3ba924d05b5419576f5219b Author: shtykh_roman <rshtykh@yahoo.com> Date: 2016-12-26T03:17:53Z ROCKETMQ-13 Wrong log level for AcceptSocketService termination. Additionally, added code comments and did a cleanup. JIRA issue: https://issues.apache.org/jira/browse/ROCKETMQ-13
          Hide
          roman_s Roman Shtykh added a comment -

          Ready for the review.
          vongosling Willem Jiang

          Show
          roman_s Roman Shtykh added a comment - Ready for the review. vongosling Willem Jiang
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user shroman closed the pull request at:

          https://github.com/apache/incubator-rocketmq/pull/12

          Show
          githubbot ASF GitHub Bot added a comment - Github user shroman closed the pull request at: https://github.com/apache/incubator-rocketmq/pull/12
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user shroman commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/12

          Merged to master by Willem.

          Show
          githubbot ASF GitHub Bot added a comment - Github user shroman commented on the issue: https://github.com/apache/incubator-rocketmq/pull/12 Merged to master by Willem.

            People

            • Assignee:
              roman_s Roman Shtykh
              Reporter:
              roman_s Roman Shtykh
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development