Uploaded image for project: 'Apache RocketMQ'
  1. Apache RocketMQ
  2. ROCKETMQ-11

Improve concision - Reuse local variable 'brokerAddrs' in RouteInfoManager.getSystemTopicList method

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0.0-incubating
    • Component/s: None
    • Labels:

      Description

      Tiny improvement to make code concise.
      Firstly I thought it's for concurrency consideration. Then I realize it's not.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user naughtybear commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/8

          Hi @zhouxinyu ,

          Sorry.
          I just start learning and wanna contributing, it's very nice of you to guide me.

          Code concision improvement.
          JIRA Issue: https://issues.apache.org/jira/browse/ROCKETMQ-11

          Show
          githubbot ASF GitHub Bot added a comment - Github user naughtybear commented on the issue: https://github.com/apache/incubator-rocketmq/pull/8 Hi @zhouxinyu , Sorry. I just start learning and wanna contributing, it's very nice of you to guide me. Code concision improvement. JIRA Issue: https://issues.apache.org/jira/browse/ROCKETMQ-11
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user naughtybear commented on the issue:

          https://github.com/apache/incubator-rocketmq/pull/8

          @vongosling
          Hi,
          two places still not align with the pr procedure.
          1. pull request title should be "ROCKETMQ-11 Improve concision - Reuse local variable 'brokerAddrs' in RouteInfoManager.getSystemTopicList method #8"
          2. commit comment should be "ROCKETMQ-11 Improve concision - Reuse local variable 'brokerAddrs' in RouteInfoManager.getSystemTopicList method, close apache/incubator-rocketmq#8"

          Am I right? If so, I need start a new pull request and modify JIRA info to keep aligned.
          Many thanks.

          Show
          githubbot ASF GitHub Bot added a comment - Github user naughtybear commented on the issue: https://github.com/apache/incubator-rocketmq/pull/8 @vongosling Hi, two places still not align with the pr procedure. 1. pull request title should be " ROCKETMQ-11 Improve concision - Reuse local variable 'brokerAddrs' in RouteInfoManager.getSystemTopicList method #8" 2. commit comment should be " ROCKETMQ-11 Improve concision - Reuse local variable 'brokerAddrs' in RouteInfoManager.getSystemTopicList method, close apache/incubator-rocketmq#8" Am I right? If so, I need start a new pull request and modify JIRA info to keep aligned. Many thanks.

            People

            • Assignee:
              vongosling vongosling
              Reporter:
              erichan hanzhaozhan
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development