VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    Description

      Clirr reports this error:
      Removed org.apache.commons.rng.sampling.distribution.SamplerBase from the list of superclasses
      for this class:
      org.apache.commons.rng.sampling.distribution.BoxMullerLogNormalSampler

      It is quite true.
      However, no functionality inherited from SamplerBase could have been used since a null was passed to its constructor (i.e. any call to a method from the base class would trigger a NullPointerException).

      Moreover:

      • SamplerBase is only meant for internal usage,
      • it only contains protected methods,
      • BoxMullerLogNormalSampler is going to be flagged as @deprecated in the next release.

      Hence, I think that it is quite safe to release a 1.1 version (i.e. no change in major number!) despite this incompatibility.

      Please confirm.

      See also the discussion on the "dev" ML.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Unassigned Unassigned
            erans Gilles Sadowski
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment