[RNG-146] GaussianSampler should not allow infinite standard deviation

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 1.3
• Fix Version/s: 1.4
• Component/s: sampling
• Assignee: Unassigned
• Reporter: Alex Herbert
• Created: 24/Jun/21 11:35
• Updated: 13/Sep/21 10:40
• Resolved: 02/Aug/21 11:15

Description

The GaussianSampler requires the standard deviation is strictly positive. It allows an infinite value. This will produce a NaN output if the NormalizedGaussianSampler returns 0:

@Test
public void testInfiniteStdDev() {
    NormalizedGaussianSampler gauss = new NormalizedGaussianSampler() {
        @Override
        public double sample() {
            return 0;
        }
    };
    GaussianSampler s = new GaussianSampler(gauss, 0, Double.POSITIVE_INFINITY);
    Assert.assertEquals(Double.NaN, s.sample(), 0.0);
}

A fix is to require the standard deviation is finite.