[RIVER-348] Possible race condition in net.jini.lookup.ServiceDiscoveryManager addProxyReg

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: River_2.1.1, River_2.1.2, River_2.2.0, River_2.2.1, River_2.2.2
• Fix Version/s: River_3.0.0
• Assignee: Unassigned
• Reporter: Patricia Shanahan
• Created: 29/Aug/10 19:19
• Updated: 04/Dec/15 12:21
• Resolved: 04/Dec/15 12:13

Description

SDM appears to assume that tasks with sequence numbers are added to their TaskManager in ascending sequence number order. The method addProxyReg increments the sequence number in a serviceIdMap synchronized block, but does not add the task to its TaskManager until outside the block. leaving a small window during which another task could be created with higher sequence number but added to the TaskManager first.

There is no known test case reproducing this, so it is difficult to be sure there is nothing else preventing the problem from happening.

The fix wold be to move the cacheTaskMgr.add(treg); call inside the synchronized block.