River
  1. River
  2. RIVER-286

[PATCH] iterators on synchronized collections still need synchronization

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: River_2.1.2
    • Component/s: com_sun_jini_mahalo
    • Labels:
      None

      Description

      Code creates a collection with Collections.synchronizedMap, and then iterates the collection without synchronizing. This is a mistake as a map can't impose synchronization on the iterator. This patch fixes this.

        Activity

        Hide
        Mark Brouwer added a comment -

        Applied patch and also corrected some javadoc and cleaned the unused import statements.

        Show
        Mark Brouwer added a comment - Applied patch and also corrected some javadoc and cleaned the unused import statements.
        Hide
        Mark Brouwer added a comment -

        Although Dave is correct, in this case there is no real harm as iterating takes place while there is no concurrent access against the map (). Nevertheless applying the patch is a good thing to do.

        Show
        Mark Brouwer added a comment - Although Dave is correct, in this case there is no real harm as iterating takes place while there is no concurrent access against the map (). Nevertheless applying the patch is a good thing to do.
        Hide
        Dave Brosius added a comment -

        switch to patch file

        Show
        Dave Brosius added a comment - switch to patch file

          People

          • Assignee:
            Mark Brouwer
            Reporter:
            Dave Brosius
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development