River
  1. River
  2. RIVER-286

[PATCH] iterators on synchronized collections still need synchronization

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: River_2.1.2
    • Component/s: com_sun_jini_mahalo
    • Labels:
      None

      Description

      Code creates a collection with Collections.synchronizedMap, and then iterates the collection without synchronizing. This is a mistake as a map can't impose synchronization on the iterator. This patch fixes this.

        Activity

        Dave Brosius created issue -
        Dave Brosius made changes -
        Field Original Value New Value
        Attachment synchronize_iterator.diff [ 12374630 ]
        Hide
        Dave Brosius added a comment -

        switch to patch file

        Show
        Dave Brosius added a comment - switch to patch file
        Dave Brosius made changes -
        Attachment synchronize_iterator.patch [ 12374643 ]
        Dave Brosius made changes -
        Attachment synchronize_iterator.diff [ 12374630 ]
        Hide
        Mark Brouwer added a comment -

        Although Dave is correct, in this case there is no real harm as iterating takes place while there is no concurrent access against the map (). Nevertheless applying the patch is a good thing to do.

        Show
        Mark Brouwer added a comment - Although Dave is correct, in this case there is no real harm as iterating takes place while there is no concurrent access against the map (). Nevertheless applying the patch is a good thing to do.
        Mark Brouwer made changes -
        Assignee Mark Brouwer [ marbro ]
        Mark Brouwer made changes -
        Fix Version/s AR2 [ 12312604 ]
        Hide
        Mark Brouwer added a comment -

        Applied patch and also corrected some javadoc and cleaned the unused import statements.

        Show
        Mark Brouwer added a comment - Applied patch and also corrected some javadoc and cleaned the unused import statements.
        Mark Brouwer made changes -
        Resolution Fixed [ 1 ]
        Status Open [ 1 ] Resolved [ 5 ]
        Mark Brouwer made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        32d 15h 22m 1 Mark Brouwer 06/Mar/08 21:04
        Resolved Resolved Closed Closed
        2d 15h 43m 1 Mark Brouwer 09/Mar/08 12:48

          People

          • Assignee:
            Mark Brouwer
            Reporter:
            Dave Brosius
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development