[RIVER-282] Suspect exception cast

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: River_3.0.0
• Component/s: com_sun_jini_fiddler

Environment

n/a

• Assignee: Peter Firmstone
• Reporter: David Brosius
• Created: 02/Feb/08 04:47
• Updated: 05/Dec/15 04:45
• Resolved: 05/Dec/15 04:45

Description

FiddlerImpl does this
-------------------

private void handleActivatableInitThrowable(Throwable t) 
                                            throws IOException,
                                                   ActivationException,
                                                   ConfigurationException,
                                                   LoginException,
                                                   ClassNotFoundException
    {
        handleInitThrowable(t);
        if (t instanceof ActivationException) {
            throw (ActivationException)t;
        } else if (t instanceof LoginException) {
            throw (ClassNotFoundException)t;
        } else {
            throw new AssertionError(t);
        }//endif

-----------------

the concerning part is

} else if (t instanceof LoginException) {
            throw (ClassNotFoundException)t;

if t is an instanceof LoginException, i don't think it can be cast to ClassNotFoundException.