River
  1. River
  2. RIVER-25

Improve logging for JoinManager at INFO and WARNING level

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: jtsk_2.1
    • Fix Version/s: River_2.1.2
    • Component/s: net_jini_lookup
    • Labels:
      None

      Description

      All logging at the INFO level lacks context information (the proxy for which an exception occurs) and as such the logging is not very helpful with troubleshooting.

      INFO: JoinManager - failure
      java.rmi.NoSuchObjectException: no such object in table
              at net.jini.jeri.BasicObjectEndpoint.executeCall(BasicObjectEndpoint.java:420)
              at net.jini.jeri.BasicInvocationHandler.invokeRemoteMethodOnce(BasicInvocationHandler.java:806)
              at net.jini.jeri.BasicInvocationHandler.invokeRemoteMethod(BasicInvocationHandler.java:659)
              at net.jini.jeri.BasicInvocationHandler.invoke(BasicInvocationHandler.java:528)
              at org.cheiron.seven.proxy.BasicInvocationHandler.invokeMethod(BasicInvocationHandler.java:323)
              at org.cheiron.seven.proxy.BasicInvocationHandler.invoke(BasicInvocationHandler.java:152)
              at org.cheiron.seven.proxy.StubInvokerHandler.invoke(StubInvokerHandler.java:171)
              at org.cheiron.seven.proxy.BasicInvocationHandler.invokeMethod(BasicInvocationHandler.java:323)
              at org.cheiron.seven.proxy.ServiceStubProxyHandler.specializedInvoke(ServiceStubProxyHandler.java:199)
              at org.cheiron.seven.proxy.BasicInvocationHandler.invoke(BasicInvocationHandler.java:142)
              at com.sun.jini.reggie.$Proxy298.renewServiceLease(Unknown Source)
              at com.sun.jini.reggie.ServiceLease.doRenew(ServiceLease.java:98)
              at com.sun.jini.lease.AbstractLease.renew(AbstractLease.java:94)
              at net.jini.lease.LeaseRenewalManager.renewAll(LeaseRenewalManager.java:1465)
              at net.jini.lease.LeaseRenewalManager.access$500(LeaseRenewalManager.java:349)
              at net.jini.lease.LeaseRenewalManager$RenewTask.run(LeaseRenewalManager.java:489)
              at com.sun.jini.thread.TaskManager$TaskThread.run(TaskManager.java:331) 
      

      A similar similar problem exists with two lease WARNING s in ProxyReg.register.

      1. RIVER-25.patch
        8 kB
        Mark Brouwer

        Activity

        Mark Brouwer created issue -
        Mark Brouwer made changes -
        Field Original Value New Value
        Status Open [ 1 ] In Progress [ 3 ]
        Mark Brouwer made changes -
        Component/s net_jini_lookup [ 12311839 ]
        Affects Version/s jtsk_2.1 [ 12312606 ]
        Mark Brouwer made changes -
        Fix Version/s AR2 [ 12312604 ]
        Hide
        Mark Brouwer added a comment -

        Proposed patch for review.

        Show
        Mark Brouwer added a comment - Proposed patch for review.
        Mark Brouwer made changes -
        Attachment RIVER-25.patch [ 12383198 ]
        Mark Brouwer made changes -
        Summary Improve logging for JoinManager at INFO level Improve logging for JoinManager at INFO and WARNING level
        Description All logging at the {{INFO}} level lacks context information (the proxy for which an exception occurs) and as such the logging is not very helpful with troubleshooting.

        {noformat:nopanel=true}
        INFO: JoinManager - failure
        java.rmi.NoSuchObjectException: no such object in table
                at net.jini.jeri.BasicObjectEndpoint.executeCall(BasicObjectEndpoint.java:420)
                at net.jini.jeri.BasicInvocationHandler.invokeRemoteMethodOnce(BasicInvocationHandler.java:806)
                at net.jini.jeri.BasicInvocationHandler.invokeRemoteMethod(BasicInvocationHandler.java:659)
                at net.jini.jeri.BasicInvocationHandler.invoke(BasicInvocationHandler.java:528)
                at org.cheiron.seven.proxy.BasicInvocationHandler.invokeMethod(BasicInvocationHandler.java:323)
                at org.cheiron.seven.proxy.BasicInvocationHandler.invoke(BasicInvocationHandler.java:152)
                at org.cheiron.seven.proxy.StubInvokerHandler.invoke(StubInvokerHandler.java:171)
                at org.cheiron.seven.proxy.BasicInvocationHandler.invokeMethod(BasicInvocationHandler.java:323)
                at org.cheiron.seven.proxy.ServiceStubProxyHandler.specializedInvoke(ServiceStubProxyHandler.java:199)
                at org.cheiron.seven.proxy.BasicInvocationHandler.invoke(BasicInvocationHandler.java:142)
                at com.sun.jini.reggie.$Proxy298.renewServiceLease(Unknown Source)
                at com.sun.jini.reggie.ServiceLease.doRenew(ServiceLease.java:98)
                at com.sun.jini.lease.AbstractLease.renew(AbstractLease.java:94)
                at net.jini.lease.LeaseRenewalManager.renewAll(LeaseRenewalManager.java:1465)
                at net.jini.lease.LeaseRenewalManager.access$500(LeaseRenewalManager.java:349)
                at net.jini.lease.LeaseRenewalManager$RenewTask.run(LeaseRenewalManager.java:489)
                at com.sun.jini.thread.TaskManager$TaskThread.run(TaskManager.java:331)
        {noformat}
        All logging at the {{INFO}} level lacks context information (the proxy for which an exception occurs) and as such the logging is not very helpful with troubleshooting.

        {noformat:nopanel=true}
        INFO: JoinManager - failure
        java.rmi.NoSuchObjectException: no such object in table
                at net.jini.jeri.BasicObjectEndpoint.executeCall(BasicObjectEndpoint.java:420)
                at net.jini.jeri.BasicInvocationHandler.invokeRemoteMethodOnce(BasicInvocationHandler.java:806)
                at net.jini.jeri.BasicInvocationHandler.invokeRemoteMethod(BasicInvocationHandler.java:659)
                at net.jini.jeri.BasicInvocationHandler.invoke(BasicInvocationHandler.java:528)
                at org.cheiron.seven.proxy.BasicInvocationHandler.invokeMethod(BasicInvocationHandler.java:323)
                at org.cheiron.seven.proxy.BasicInvocationHandler.invoke(BasicInvocationHandler.java:152)
                at org.cheiron.seven.proxy.StubInvokerHandler.invoke(StubInvokerHandler.java:171)
                at org.cheiron.seven.proxy.BasicInvocationHandler.invokeMethod(BasicInvocationHandler.java:323)
                at org.cheiron.seven.proxy.ServiceStubProxyHandler.specializedInvoke(ServiceStubProxyHandler.java:199)
                at org.cheiron.seven.proxy.BasicInvocationHandler.invoke(BasicInvocationHandler.java:142)
                at com.sun.jini.reggie.$Proxy298.renewServiceLease(Unknown Source)
                at com.sun.jini.reggie.ServiceLease.doRenew(ServiceLease.java:98)
                at com.sun.jini.lease.AbstractLease.renew(AbstractLease.java:94)
                at net.jini.lease.LeaseRenewalManager.renewAll(LeaseRenewalManager.java:1465)
                at net.jini.lease.LeaseRenewalManager.access$500(LeaseRenewalManager.java:349)
                at net.jini.lease.LeaseRenewalManager$RenewTask.run(LeaseRenewalManager.java:489)
                at com.sun.jini.thread.TaskManager$TaskThread.run(TaskManager.java:331)
        {noformat}

        A similar similar problem exists with two lease {{WARNING}} s in {{ProxyReg.register}}.
        Mark Brouwer made changes -
        Attachment RIVER-25.patch [ 12383198 ]
        Hide
        Mark Brouwer added a comment -

        Added a fix suggested by Bob Scheifler.

        Show
        Mark Brouwer added a comment - Added a fix suggested by Bob Scheifler.
        Mark Brouwer made changes -
        Attachment RIVER-25.patch [ 12383769 ]
        Hide
        Mark Brouwer added a comment -

        Fixed with suggestion by Bob S. incorporated in the patch.

        Show
        Mark Brouwer added a comment - Fixed with suggestion by Bob S. incorporated in the patch.
        Mark Brouwer made changes -
        Resolution Fixed [ 1 ]
        Status In Progress [ 3 ] Resolved [ 5 ]
        Peter Firmstone made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Mark Brouwer
            Reporter:
            Mark Brouwer
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development