[REEF-858] Enable StyleCop.CSharp.MaintainabilityRules and fix violations

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.14
• Component/s: REEF.NET
• Assignee: Dongjoon Hyun
• Reporter: Anupam
• Created: 20/Oct/15 17:02
• Updated: 25/Nov/15 23:46
• Resolved: 25/Nov/15 23:46

Description

This issue enables the followings StyleCop.CSharp.MaintainablilityRules and fixing violations.

• CodeAnalysisSuppressionMustHaveJustification
• DebugAssertMustProvideMessageText
• DebugFailMustProvideMessageText
• FileMayOnlyContainASingleNamespace
• StatementMustNotUseUnnecessaryParenthesis
• ArithmeticExpressionsMustDeclarePrecedence
• ConditionalExpressionsMustDeclarePrecedence
• RemoveDelegateParenthesisWhenPossible
• AttributeConstructorMustNotUseUnnecessaryParenthesis
• RemoveUnnecessaryCode

The following rules are excluded since they does not fit well with current REEF coding style.

• AccessModifierMustBeDeclared
• FieldsMustBePrivate
• FileMayOnlyContainASingleClass

Issue Links

• links to: Link to PR