[REEF-779] Implement both null and type checking in equals functions

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.12
• Fix Version/s: 0.13
• Assignee: Dongjoon Hyun
• Reporter: Dongjoon Hyun
• Created: 23/Sep/15 05:53
• Updated: 24/Sep/15 02:48
• Resolved: 23/Sep/15 18:02

Description

`equals` functions should handle `null` and other type objects. Most REEF classes already implements that function properly like the following.

public boolean equals(final Object o) {
    if (this == o) {
      return true;
    }
    if (o == null || getClass() != o.getClass()) {
      return false;
    }
    ...
}

This issue addresses the following classes needed to be changed.

• reef-io : StringIdentifier
• reef-tang: TangImpl.java, AbstractNode, ConstructorArgImpl, ConstructorDefImpl.java
• reef-wake: SocketRemoteIdentifier, Tuple2, TestRemoteIdentifier

Issue Links

• links to: Link to PR