Details
-
Sub-task
-
Status: Reopened
-
Minor
-
Resolution: Unresolved
-
None
-
None
-
None
Description
O.A.R.Tests.Functional.ML.KMeans.TestKMeans.TestKMeansOnDirectRunViaFileSystem failed on AppVeyor with error
System.InvalidOperationException : The new loss 14658.95 is larger than previous loss 14658.95, while loss function must be monotonically decreasing across iterations
I doubt that the new loss was really significantly less than the previous one, since the displayed values are identical. But the test uses exact comparisons of floating-point numbers, which occasionally might produce unexpected results.
We should probably replace exact comparisons with a proper comparison function, as described here. Note that this comparison is done in two files - TestKMeans.cs and KMeansMasterTask.cs.