[REEF-1537] LogicalTimer can cause a race condition in RuntimeClock

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Component/s: REEF-Common
• Labels: race-condition test
• Assignee: Sergiy Matusevych
• Reporter: Sergiy Matusevych
• Created: 22/Aug/16 19:57
• Updated: 20/Mar/17 23:21

Description

RuntimeClock has a concept of injectable timer, and in many unit tests, we use LogicalTimer to speed up the operations. Unfortunately, RuntimeClock still depends on the system timer internally: it uses Object.wait(time) calls in the event loop. That can cause race conditions when using LogicalTimer, e.g. in unit test ClockTest.testAlarmOrder()

The solution would be to move the .wait() functionality into the logical timer and use that inside the RuntimeClock.