[REEF-1117] Update change_version.py by cleaning up incubating-related logic

• Type: Sub-task
• Status: Resolved
• Priority: Minor
• Resolution: Duplicate
• Assignee: Dongjoon Hyun
• Reporter: Dongjoon Hyun
• Created: 30/Dec/15 08:11
• Updated: 05/Jan/16 20:25
• Resolved: 05/Jan/16 20:25

Description

This issue removes '<RemoveIncubating>' handling logics in `change_version.py`.

-    r1 = re.compile('<RemoveIncubating>(.*?)</RemoveIncubating>')
-    r2 = re.compile('<IsSnapshot>(.*?)</IsSnapshot>')
-    r3 = re.compile('<SnapshotNumber>(.*?)</SnapshotNumber>')
+    r1 = re.compile('<IsSnapshot>(.*?)</IsSnapshot>')
+    r2 = re.compile('<SnapshotNumber>(.*?)</SnapshotNumber>')
...
-        if "<RemoveIncubating>" and "</RemoveIncubating>" in line and is_snapshot=="false":
-            old_remove_incubating = r1.search(line).group(1)
-            changed_str += line.replace(old_remove_incubating, "true")
-        elif "<IsSnapshot>" in line and "</IsSnapshot>" in line:
-            old_is_snapshot = r2.search(line).group(1)
+        if "<IsSnapshot>" in line and "</IsSnapshot>" in line:
+            old_is_snapshot = r1.search(line).group(1)
             changed_str += line.replace(old_is_snapshot, is_snapshot)
         elif "<SnapshotNumber>" in line and "</SnapshotNumber>" in line and is_snapshot=="false":
-            old_snapshot_number = r3.search(line).group(1)
+            old_snapshot_number = r2.search(line).group(1)
             changed_str += line.replace(old_snapshot_number, "00")
         else:
             changed_str += line

Issue Links

• Is contained by: REEF-989 Update release scripts and release manager guide
• relates to: REEF-989 Update release scripts and release manager guide
• links to: Link to PR