Uploaded image for project: 'REEF (Retired)'
  1. REEF (Retired)
  2. REEF-1115

Increase maximum depth of package name of Tint and fix example images

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 0.14
    • Tang
    • None

    Description

      This issue fixes the following three items.

      1. Tint.java
      Historically, `Tint` uses 4 to determine the minimum depth of package name. In order to preserve the behavior, it should be increase into 5 because we use the package prefix 'org.apache.reef' instead of 'com.microsoft'. This change is needed to be consistent with `lang/java/reef-tang/README.md`.

      Tint.java
                 final String[] tok = fullName.split("\\.");
                 final StringBuffer sb = new StringBuffer(tok[0]);
                 for (int j = 1; j < tok.length; j++) {
      -            if (tok[j].matches("^[A-Z].*") || j > 4) {
      +            if (tok[j].matches("^[A-Z].*") || j > 5) {
      

      2. tangdoc.png
      We need to replace `com.microsoft.tang.examples.timer` with `org.apache.reef.tang.examples.timer`.

      3. tooltip.png
      We need to replace `com.microsoft.tang.examples.Timer.Seconds` with `org.apache.reef.tang.examples.Timer.Seconds`.

      Attachments

        Issue Links

          Activity

            People

              dongjoon Dongjoon Hyun
              dongjoon Dongjoon Hyun
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: