[REEF-1055] Enable StyleCop.CSharp.ReadabilityRules and fix violations

• Type: Sub-task
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.14
• Component/s: REEF.NET
• Assignee: Mariia Mykhailova
• Reporter: Mariia Mykhailova
• Created: 09/Dec/15 20:35
• Updated: 16/Dec/15 00:57
• Resolved: 16/Dec/15 00:57

Description

I suggest we adopt all rules, except:

• SA1101: PrefixLocalCallsWithThis and SA1126: PrefixCallsCorrectly which require that we add this. whenever we reference class member. For similar issue in Java we decided against it.
• SA1115: ParameterMustFollowComma which produces lots of violations which look like false positives (we don't have empty lines in lists of parametes).
• SA1116: SplitParametersMustStartOnLineAfterDeclaration and SA1117: ParametersMustBeOnSameLineOrSeparateLines which increase code length for methods with multiple short parameters without increasing readability.

The rest of the rules produce under 200 violations.