[REEF-1047] ConstructorDefImpl.hashCode function should consider `className`

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.14
• Component/s: Tang
• Assignee: Dongjoon Hyun
• Reporter: Dongjoon Hyun
• Created: 07/Dec/15 15:58
• Updated: 07/Dec/15 16:53
• Resolved: 07/Dec/15 16:53

Description

`hashCode` function should consider all fields to distinguish objects. This issue fixes the `hashCode` function of `ConstructorDefImpl` class to consider `className` and `args` together.

ConstructorDefImpl.java

   public int hashCode() {
     final ConstructorArg[] argsSort = getArgs().clone();
     Arrays.sort(argsSort);
-    return Arrays.hashCode(argsSort);
+    int result = Arrays.hashCode(argsSort);
+    result = 31 * result + (this.className == null ? 0 : this.className.hashCode());
+    return result;
   }

Issue Links

• links to: Link to PR