Uploaded image for project: 'REEF (Retired)'
  1. REEF (Retired)
  2. REEF-1046

Fix typos in TestConfigurationBuilder and fill all TODO package-info in Tang

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 0.14
    • Tang
    • None

    Description

      This issue fixes the typos in `TestConfigurationBuilder.java` and fill all remaining TODO package-info in `Tang` module.

      TestConfigurationBuilder.java
      -  public void nullStringVaueTest() {
      +  public void nullStringValueTest() {
           thrown.expect(IllegalStateException.class);
           thrown.expectMessage("The value null set to the named parameter is illegal: class " +
      -        "org.apache.reef.tang.implementation.java.TestConfigurationBuilder$NamedParamterNoDefault$NamedString");
      +        "org.apache.reef.tang.implementation.java.TestConfigurationBuilder$NamedParameterNoDefault$NamedString");
       
           Tang.Factory.getTang().newConfigurationBuilder()
      -        .bindNamedParameter(NamedParamterNoDefault.NamedString.class, (String) null)
      +        .bindNamedParameter(NamedParameterNoDefault.NamedString.class, (String) null)
               .build();
         }
       
      -  static class NamedParamterNoDefault {
      +  static class NamedParameterNoDefault {
           private final String str;
       
           @Inject
      -    NamedParamterNoDefault(@Parameter(NamedString.class) final String str) {
      +    NamedParameterNoDefault(@Parameter(NamedString.class) final String str) {
             this.str = str;
           }
      

      Attachments

        Issue Links

          Activity

            People

              dongjoon Dongjoon Hyun
              dongjoon Dongjoon Hyun
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: