[RAVE-331] Error when trying to upload a duplicate gadget url to widget store

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.5-INCUBATING
• Fix Version/s: 0.6-INCUBATING
• Assignee: Tony Carlucci
• Reporter: Tony Carlucci
• Created: 01/Nov/11 14:57
• Updated: 13/Jan/12 15:40
• Resolved: 04/Nov/11 11:19

Description

How to Reproduce
--------------------------
1) Login to Rave as any user
2) Upload a gadget to the widget store - verify it was added successfully
3) Go back and try to add the same gadget url again
4) You will see the standard "rave has suffered a brief meltdown" page

The issue is that the DefaultWidgetService.registerNewWidget function returns a null Widget object if it finds the URL already in the system. The RavePermissionEvaluator.hasPermission functions are not properly dealing with potential null objects and thus a NPE is thrown.

How to Fix
----------------
1) Improve the RavePermissionEvaluator.hasPermission methods to check for and safely handle possible null objects.

Issue Links

• blocks: RAVE-332 Change logic of adding a duplicate widget