[RATIS-949] Address Sonar code quality violations

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Implemented
• Affects Version/s: 0.5.0
• Labels: codesmell sonar
• Target Version/s: 1.0.0
• Assignee: Dinesh Chitlangia
• Reporter: Dinesh Chitlangia
• Created: 28/May/20 16:58
• Updated: 02/Nov/23 17:53
• Resolved: 02/Nov/23 17:53

Description

As sonar has been enabled for Ratis, this umbrella Jira is logged to track all Sonar fixes.

https://sonarcloud.io/dashboard?id=apache_incubator-ratis

 

Sub tasks will be created shortly in a way that similar violations are addressed in one Jira to make it easy for the reviewers too.

Sub-Tasks

• Classes that implement AutoCloseable should call "close()" when it should be terminated: Resolved
• Handle Exceptions appropriately: Resolved
• Avoid NPE: Resolved
• XML Parsers should not be vulnerable to XXE attacks: Resolved
• Resources should be closed: Resolved
• Return values should not be ignored: Resolved
• Move constants to a class or enum: Resolved
• Use format specifier instead of string concat: Resolved