[RATIS-944] Fix FileStoreStateMachine#read

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Invalid
• Affects Version/s: 0.5.0
• Assignee: Dinesh Chitlangia
• Reporter: Dinesh Chitlangia
• Created: 25/May/20 05:46
• Updated: 11/Jun/20 13:49
• Resolved: 11/Jun/20 13:49

Description

While reading the code, it appears that the FileStoreStateMachine#read expects 

FileStoreRequestProto.RequestCase.WRITEHEADER instead of the READHEADER

It also attempts to process a Write Header and send as a Read Response.

public CompletableFuture<ByteString> read(LogEntryProto entry) {
.
.
.
 if (proto.getRequestCase() != FileStoreRequestProto.RequestCase.WRITEHEADER) {
 return null;
 }

 final WriteRequestHeaderProto h = proto.getWriteHeader();
 CompletableFuture<ExamplesProtos.ReadReplyProto> reply =
 files.read(h.getPath().toStringUtf8(), h.getOffset(), h.getLength());

 return reply.thenApply(ExamplesProtos.ReadReplyProto::getData);
}

 

 May be I am just missing something here.