[RATIS-628] Simplify the code in LogSegment

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.4.0
• Component/s: server
• Assignee: Tsz-wo Sze
• Reporter: Tsz-wo Sze
• Created: 19/Jul/19 18:15
• Updated: 26/Jul/19 12:26
• Resolved: 26/Jul/19 12:26

Description

This is a followup on RATIS-625. This JIRE is to simplify the code in LogSegment:

• LogRecordWithEntry can be removed.
• hasEntryCache can be removed.
• appendToOpenSegment should take only a single LogEntryProto parameter.

Issue Links

• relates to: RATIS-625 LogSegment#append leaks entryCache when the entries are loaded on a restart.