[RATIS-2132] Revert RATIS-2099 due to its performance regression

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Done
• Affects Version/s: 3.1.0
• Fix Version/s: 3.1.1
• Assignee: Duong
• Reporter: Duong
• Created: 29/Jul/24 23:58
• Updated: 16/Oct/24 03:31
• Resolved: 26/Aug/24 18:15

Description

This commit creates a significant extra cost in the critical path (which is run sequentially) of Ratis appendTransaction. 

This seems to be a premature optimization. One or two instances of TermIndex per request are basically nothing (unless we create hundreds/thousands of them per request).   Short-lived POJO like this are the best to be dealt with by java GC/heap.

More details are the parent Jira RATIS-2129.

Issue Links

• is caused by: RATIS-2099 Cache TermIndexImpl instead of using anonymous class
• relates to: RATIS-2101 Move TermIndex.PRIVATE_CACHE to Util.CACHE
• links to: GitHub Pull Request #1126