[RATIS-2109] RaftLogBase#updateCommitIndex should return true only if commitIndex is increased

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.1.1
• Component/s: server
• Assignee: Ivan Andika
• Reporter: Ivan Andika
• Created: 05/Jun/24 04:03
• Updated: 05/Jun/24 12:02
• Resolved: 05/Jun/24 12:02

Description

RaftLogBase#updateCommitIndex returns true regardless whether commit index is actually increased (RaftLogIndex#updateIncreasingly returns true). This can cause unnecessary StateMachineUpdater notification

We can change it so that RaftLogBase#updateCommitIndex only returns true if commit index is actually increased. 

Note: For leader ServerState#updateCommitIndex is called only if there are entries to commit (i.e. majority > oldLasCommitted), so RaftLogBase#updateCommitIndex should increase the commit index of leader.

Issue Links

• links to: GitHub Pull Request #1109