Details
-
Improvement
-
Status: Resolved
-
Major
-
Resolution: Fixed
-
3.0.0, 3.0.1
-
None
Description
Today, Ratis sometimes logs entire LogEntry messages with StateMachine data, for example:
@Override public CompletableFuture<AppendEntriesReplyProto> appendEntriesAsync( ReferenceCountedObject<AppendEntriesRequestProto> requestRef) throws IOException { ..... } catch(Exception t) { LOG.error("{}: Failed appendEntries* {}", getMemberId(), toAppendEntriesRequestString(r), t); .... } }
This makes the logs painful to read for large StateMachine data scenarios. Specifically, in Ozone, StateMachine data is usually 4mb, and we see 4M-letters log lines which are very hard to navigate around.
We should either filter StateMachine data when logging or restrict the log message to a certain limit.
Attachments
Attachments
Issue Links
- links to