[RATIS-2049] Suppress Sonar warning for volatile objects

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.1.0
• Assignee: Xinyu Tan
• Reporter: Xinyu Tan
• Created: 22/Mar/24 09:30
• Updated: 25/Mar/24 15:14
• Resolved: 25/Mar/24 15:14

Description

Currently, there are about 40 bugs on Sonar for [Ratis|https://sonarcloud.io/summary/new_code?id=apache-ratis], with more than half of these issues stemming from the use of volatile fields to decorate objects rather than primitive data types.

Theoretically, volatile is indeed intended for use with primitive data types only, as decorating objects can lead to visibility issues. To avoid certain concurrency problems, using AtomicReference is recommended. However, it seems that for certain types of objects that are not modified, this usage does not result in bugs?

I'm not sure what the Ratis community's stance is on this code style. If there are confirmed rules and some code that could be optimized, I'm willing to undertake these tasks to avoid potential concurrency issues and eliminate Sonar bugs.

Tsz-wo Sze What's your opinion?

Issue Links

• links to: GitHub Pull Request #1057